chore: sync external contributions

[ludamad]

This is a workaround for CI not triggering secrets on external PRs. In the future we should perhaps automate this.

Features:

fix: Use Date.now() in case performance.now() is undefined (https://github.com/AztecProtocol/aztec-packages/pull/6982)
It seems like `performance.now()` used in `foundation/timer.ts` isn't
supported in specific environment, such as certain browser extension
apps, web workers, embedded browsers, etc... In my case, Metamask's Snap
server app doesn't support it, causing an error in initiating a
transaction. I [patched
it](https://github.com/porco-rosso-j/aztec-snap/tree/0.41.0/patches) but
thought it'd be good to add the fix here as other developers might face
it.

<img width="590" alt="Screenshot 2024-06-08 at 20 09 39"
src="https://github.com/AztecProtocol/aztec-packages/assets/88586592/fdc8ddae-f7f9-4161-9cd4-e87357f4bed3">

This PR doesn't replace `performance.now()` but lets Timer class's
methods switch to use `Date.now()` when `peformance` is undefined.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 65.2 (-88%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 204 (+214%)
• avm_simulation_time_ms (Token:transfer_public): 63.6 (+46%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,726	1,545 (-1%)	700	787 (+3%)	773 (-1%)
proof_construction_time_sha256_30_ms	11,516	3,062	1,370	1,417	1,487 (+2%)
proof_construction_time_sha256_100_ms	44,813	12,060	5,663	5,558	5,509
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	56.0 (-3%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,522	420	202	226 (+2%)	263 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,764	1,563	719	770 (+1%)	791 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,458	9,452
l1_rollup_execution_gas	610,273	610,279	610,273
l2_block_processing_time_in_ms	707 (+2%)	1,298 (+1%)	2,462
l2_block_building_time_in_ms	22,416	45,955	88,240
l2_block_rollup_simulation_time_in_ms	22,306	45,601	87,831
l2_block_public_tx_process_time_in_ms	19,195	42,159	84,544

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	5,955	8,540 (+1%)
node_database_size_in_bytes	9,478,224	12,755,024
pxe_database_size_in_bytes	9,242	15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	133 (-1%)	495	11,957	20,634	64,614	89,536	2,731	524,288
private-kernel-inner	392	1,197 (+15%)	45,467 (+1%)	92,326	64,614	89,536	2,731	2,097,152
private-kernel-tail	369 (-1%)	1,900 (-5%)	38,252 (-1%)	96,545	69,406	11,648	297	2,097,152
base-parity	6.51 (-2%)	1,801 (-9%)	2,465 (+1%)	128	64.0	2,208	2.00	131,072
root-parity	50.1	49.7 (-2%)	34,089	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,579	2,303 (-1%)	69,388	119,738	756	3,648	47.0	4,194,304
root-rollup	113 (+1%)	62.4 (-1%)	20,176 (+4%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	690 (+2%)	2,642	37,834 (+1%)	108,585	86,550	116,768	3,582	2,097,152
public-kernel-app-logic	571	3,504	39,291 (+1%)	108,585	86,550	116,768	3,582	2,097,152
public-kernel-tail	1,146	23,383 (+11%)	155,146	403,238	7,646	11,648	297	8,388,608
private-kernel-reset-small	588	2,087	43,113	120,737	64,614	89,536	2,731	2,097,152
public-kernel-teardown	583 (+1%)	3,500	38,720	108,585	86,550	116,768	3,582	2,097,152
merge-rollup	29.0 (-1%)	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	7,148	49,056 (+2%)	N/A	N/A	116,768	3,582	2,097,152
avm-circuit	N/A	N/A	935 (-1%)	N/A	N/A	83,008	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	469	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	41.3	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	2,030	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	1,045 (+2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,471	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,863	16,768	50,367 (-1%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,676 (-9%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	1,150 (+1%)	16,768	10,144 (+1%)	524,288	457
Token:transfer	1,376	9,944	5,519 (+1%)	16,768	48,359	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,394	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	76.2	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,996 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,906 (+2%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms
GasToken:_increase_public_balance	68.7
GasToken:set_portal	17.5 (-6%)
Token:constructor	96.0 (-3%)
FPC:constructor	62.5 (+1%)
GasToken:mint_public	53.3 (-3%)
Token:mint_public	⚠️ 65.2 (-88%)
Token:assert_minter_and_mint	⚠️ 204 (+214%)
SchnorrAccount:approve_public_authwit	32.6 (-7%)
FPC:prepare_fee	81.9 (-1%)
Token:transfer_public	⚠️ 63.6 (+46%)
FPC:pay_refund	71.9 (+14%)
Benchmarking:increment_balance	2,424 (-1%)
Token:_increase_public_balance	57.2 (+1%)
FPC:pay_refund_with_shielded_rebate	56.7 (+2%)

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.175 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.5	17.0	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.611	0.522	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	49.0	77.2 (+2%)	138 (+4%)	247	477 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	288	543	1,055	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.501	0.476 (+2%)	0.472 (+3%)	0.448	0.445 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.3	113	185 (+1%)	357 (+1%)	702	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	208	355	691	1,363	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.511	0.505	0.488	0.484 (+1%)	0.483 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.9
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	103
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.555

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	79,300	673,633

Transaction size based on fee payment method

| Metric | |
| - | |