fix: Allow importing notes from other contracts and inject them in the macros

[Thunkar]

Removes an overzealous check that prevented pulling note structs from imported contract dependencies. Since we make sure we only import the same struct once from the "closest" source to the root crate, it should be ok to pull notes from them (at least to generate compute_note_hash_and_optionally_a_nullifier. God I hate that name)

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 494 (+968%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 64.9 (-65%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,540 (-3%)	1,494 (-3%)	685 (-3%)	718 (-5%)	752 (-3%)
proof_construction_time_sha256_30_ms	11,344 (-4%)	3,034 (-3%)	1,354 (-4%)	1,389 (-3%)	1,419 (-3%)
proof_construction_time_sha256_100_ms	42,335 (-3%)	11,369 (-3%)	5,248 (-3%)	5,189 (-3%)	5,193 (-3%)
proof_construction_time_poseidon_hash_ms	76.0 (-3%)	33.0 (-3%)	33.0 (-3%)	55.0 (-4%)	85.0 (-3%)
proof_construction_time_poseidon_hash_30_ms	1,468 (-3%)	401 (-3%)	193 (-4%)	216 (-3%)	256 (-3%)
proof_construction_time_poseidon_hash_100_ms	5,569 (-3%)	1,514 (-3%)	697 (-3%)	737 (-5%)	761 (-4%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,460	9,476
l1_rollup_execution_gas	611,191	611,350	611,517
l2_block_processing_time_in_ms	759	1,411	2,685 (-1%)
l2_block_building_time_in_ms	20,404 (-2%)	41,773	79,564 (-3%)
l2_block_rollup_simulation_time_in_ms	20,404 (-2%)	41,773	79,564 (-3%)
l2_block_public_tx_process_time_in_ms	17,450 (-2%)	38,539	76,492 (-3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,025	9,777 (-1%)
node_database_size_in_bytes	12,419,152	16,183,376
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	99.8	374 (-1%)	12,708 (-2%)	19,418	53,878	71,872	2,179	524,288
private-kernel-inner	301 (-1%)	743 (+1%)	49,579 (+2%)	80,374	53,878	71,872	2,179	2,097,152
private-kernel-tail	1,042 (-1%)	2,436	49,143 (+2%)	61,201	62,057	14,912	399	2,097,152
base-parity	6.05 (-5%)	1,527 (+2%)	2,645	128	64.0	2,208	2.00	131,072
root-parity	48.9	67.3 (-1%)	40,628 (-4%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,497 (-1%)	4,802	90,676 (+1%)	170,330	728	3,648	47.0	4,194,304
root-rollup	109 (-1%)	84.2 (+2%)	22,602 (-6%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	531 (-2%)	2,383	43,184 (+1%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	498 (-1%)	3,390 (+4%)	41,988 (-3%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,135 (-1%)	25,492 (-5%)	179,857 (+1%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	285 (-1%)	1,087 (+1%)	29,787 (-2%)	78,065	53,878	71,872	2,179	1,048,576
public-kernel-teardown	483 (-2%)	3,373 (+3%)	42,600 (-1%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.1 (-1%)	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,328 (-1%)	50,779 (-1%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	8,792	389 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	8,792	23.8 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	8,792	1,145 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	8,792	805 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	8,792	468 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	8,792	1,577 (-2%)	14,720	52,828	2,097,152	393
Token:privately_mint_private_note	1,280	8,792	599 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	8,792	229 (-8%)	14,720	11,358 (+2%)	524,288	393
Token:transfer	1,312	8,792	1,762 (-2%)	14,720	12,903 (+2%)	524,288	393
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,256 (-9%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,691 (-6%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,708 (-6%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,662 (-10%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	22,844 (-2%)	N/A	N/A
Benchmarking:create_note	1,344	8,792	461 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	8,792	40.3	N/A	N/A	N/A	N/A
Token:unshield	1,376	8,792	1,443 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	8,792	1,985 (-1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	67.7 (-6%)	13,790
GasToken:set_portal	15.6 (+27%)	3,339
Token:constructor	92.0 (-2%)	23,692
FPC:constructor	60.7 (+18%)	13,592
GasToken:mint_public	49.8 (-1%)	10,158
Token:mint_public	⚠️ 494 (+968%)	19,034
Token:assert_minter_and_mint	⚠️ 64.9 (-65%)	12,925
AuthRegistry:set_authorized	30.2 (-2%)	7,812
FPC:prepare_fee	117 (+2%)	15,062
Token:transfer_public	30.2 (-15%)	31,218
FPC:pay_refund	129 (-5%)	25,260
Benchmarking:increment_balance	2,187	15,267
Token:_increase_public_balance	55.5 (-4%)	15,006
FPC:pay_refund_with_shielded_rebate	116 (-4%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.153 (-4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.3 (-1%)	16.6	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.595 (-1%)	0.510	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.4 (-1%)	75.8	132 (-1%)	244	473
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.484 (-1%)	0.466	0.454	0.442	0.442
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.6 (-1%)	112	183 (-1%)	352	693
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.495 (-1%)	0.501	0.484 (-1%)	0.476	0.476
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.1 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.513 (-1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,841

Transaction size based on fee payment method

| Metric | |
| - | |