Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting TLS1.2 as min for cosmosDB #3520

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

sankur-codes
Copy link
Collaborator

@sankur-codes sankur-codes commented Apr 12, 2024

Which issue this PR addresses:

Fixes ARO-6842

What this PR does / why we need it:

This PR set TLS 1.2 as minimum requirement for cosmosdb as required by Microsoft Compliance

Test plan for issue:

Tested using full-rp-dev-setup. Details added in JIRA ticket.

Is there any documentation that needs to be updated for this PR?

NA

How do you know this will function as expected in production?

Tested using full-rp-dev-setup. Details added in JIRA ticket.

@sankur-codes sankur-codes marked this pull request as ready for review April 19, 2024 06:35
@sankur-codes sankur-codes added ready-for-review priority-high High priority issue or pull request firefly Issues or Pull requests owned by Team Firefly labels Apr 19, 2024
@sankur-codes sankur-codes changed the title [Draft] Setting TLS1.2 as min for cosmoDB Setting TLS1.2 as min for cosmoDB Apr 23, 2024
@mociarain
Copy link
Collaborator

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change just a few questions to help with the review

pkg/deploy/assets/databases-development.json Show resolved Hide resolved
pkg/deploy/generator/resources_rp.go Show resolved Hide resolved
Copy link
Collaborator

@anshulvermapatel anshulvermapatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. I have just put in some comments.

pkg/util/azureclient/apiversions.go Show resolved Hide resolved
pkg/deploy/generator/resources_rp.go Show resolved Hide resolved
pkg/deploy/generator/resources_rp.go Show resolved Hide resolved
Copy link
Collaborator

@anshulvermapatel anshulvermapatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshulvermapatel anshulvermapatel merged commit e1b8a4e into master Apr 29, 2024
19 checks passed
@mociarain mociarain deleted the ankusing/ARO-5972-cosmodb-min-tls12 branch April 29, 2024 10:31
cadenmarchese added a commit that referenced this pull request May 1, 2024
@sankur-codes sankur-codes changed the title Setting TLS1.2 as min for cosmoDB Setting TLS1.2 as min for cosmosDB May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firefly Issues or Pull requests owned by Team Firefly priority-high High priority issue or pull request ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants