-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting TLS1.2 as min for cosmosDB #3520
Conversation
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change just a few questions to help with the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. I have just put in some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit e1b8a4e.
Which issue this PR addresses:
Fixes ARO-6842
What this PR does / why we need it:
This PR set TLS 1.2 as minimum requirement for cosmosdb as required by Microsoft Compliance
Test plan for issue:
Tested using full-rp-dev-setup. Details added in JIRA ticket.
Is there any documentation that needs to be updated for this PR?
NA
How do you know this will function as expected in production?
Tested using full-rp-dev-setup. Details added in JIRA ticket.