-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dependsOn for cosmosdb container deployment templates #3552
Conversation
/azp run ci,e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for digging into the issue and opening a PR. Will approve once E2E passes and I've looked at the deployment in the Azure Portal and validated that the dependencies are there.
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge on green e2e. thanks!
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up.
Which issue this PR addresses:
Fixes:-
e2e pipeline failure due to cosmos db deployment failure, related failed e2e runs:- https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=92491280&view=results
Issue was caused after following PR was merged:- #3520
What this PR does / why we need it:
Adds the dependsOn wherever needed, that was removed as part of the PR that caused issue.
Test plan for issue:
e2e should succeed. (In Progress)
Is there any documentation that needs to be updated for this PR?
No