Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependsOn for cosmosdb container deployment templates #3552

Merged
merged 1 commit into from
May 2, 2024

Conversation

rajdeepc2792
Copy link
Collaborator

Which issue this PR addresses:

Fixes:-
e2e pipeline failure due to cosmos db deployment failure, related failed e2e runs:- https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=92491280&view=results
Issue was caused after following PR was merged:- #3520

What this PR does / why we need it:

Adds the dependsOn wherever needed, that was removed as part of the PR that caused issue.

Test plan for issue:

e2e should succeed. (In Progress)

Is there any documentation that needs to be updated for this PR?

No

@rajdeepc2792
Copy link
Collaborator Author

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@kimorris27 kimorris27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for digging into the issue and opening a PR. Will approve once E2E passes and I've looked at the deployment in the Azure Portal and validated that the dependencies are there.

@rajdeepc2792
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge on green e2e. thanks!

@cadenmarchese
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cadenmarchese
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rajdeepc2792
Copy link
Collaborator Author

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yjst2012 yjst2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up.

@yjst2012 yjst2012 merged commit d67323b into master May 2, 2024
19 checks passed
@SudoBrendan SudoBrendan deleted the rajdeepc2792/fix-e2e-cosmosdb-deployment branch July 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants