-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go version to 1.20.12 #3548
Conversation
/azp run e2e, ci |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you wanna change the version in the Dockerfiles as well?
ARO-RP/Dockerfile.aro-multistage
Line 4 in 7a901cf
FROM ${REGISTRY}/ubi8/go-toolset:1.20.10 AS builder |
Good catch, the dockerfile changes are in another PR, as the go upgrading effort is separated into different tasks, feel free to take a look at it, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, guess just waiting for the PR to fix the broken E2E
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Wow, finally got E2E passed, merging now. |
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-6716
Fixes
What this PR does / why we need it:
This fixes some CVEs in the standard library which govulncheck notes:
https://pkg.go.dev/vuln/GO-2023-2382
https://pkg.go.dev/vuln/GO-2023-2186
among others patched in go-toolset
Test plan for issue:
local go unit test with
/pkg/containerinstall/install_test.go
and E2EIs there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
should be fine as long as E2E passes