Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and descriptive comments #2786

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Minor fixes and descriptive comments #2786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac87ae
Compile package translations for use in the portal
skapur12 Aug 24, 2023
a3c54b9
Remove unneeded strings
skapur12 Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/build-localization-locally.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ To build the localization translations for all languages besides English:
* Run `npm run loc:build` to build the translations, move them to the package directories, and combine them altogether in one directory
* Run `npm run build-translations` to build the full, compiled translations for the web and desktop packages

* `web/dev-server/resources/i18n` contains web translations (web + all packages)
* `web/resources/i18n` contains web translations (web + all packages)
* `desktop/resources/i18n` contains desktop translations (desktop + all packages)
2 changes: 1 addition & 1 deletion packages/bonito-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"clean:build": "bux rmrf ./build",
"clean:esm": "bux rmrf ./lib",
"clean:cjs": "bux rmrf ./lib-cjs",
"clean:generated": "bux rmrf ./src/ui-common/generated",
"clean:generated": "bux rmrf ./src/generated",
"test": "jest",
"test:coverage": "jest --collect-coverage",
"test:all": "npm run test:coverage",
Expand Down
0 ...rc/demo/form/checkbox/playground.i18n.yml → .../src/demo/form/checkbox/checkbox.i18n.yml
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions util/bux/translation-functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const writeFile = promisify(fs.writeFile);
const readFileAsync = promisify(fs.readFile);
const writeFileAsync = promisify(fs.writeFile);

// Generate bundled translations for web and desktop directories
export async function mergeAllTranslations(outputPath: string) {
const currentDirectory = process.cwd();
const rootDir = path.resolve(currentDirectory, "..");
Expand Down