Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async operations dispatched on Bootstrap or Channel may indicate completion prematurely #66

Closed
nayato opened this issue Feb 10, 2016 · 0 comments
Closed

Async operations dispatched on Bootstrap or Channel may indicate completion prematurely #66

nayato opened this issue Feb 10, 2016 · 0 comments

Comments

@nayato
Copy link
Member

nayato commented Feb 10, 2016

No description provided.

nayato added a commit to nayato/DotNetty that referenced this issue Feb 10, 2016
@nayato
Fixes premature completion of async operations (Azure#66)
5c70346 
Motivation:
Due to misuse of IEventExecutor.SubmitAsync in
DefaultChannelHandlerInvoker and Bootstrap, async operations return future
that is completed after first sync part of operation is through.

Modifications:
DefaultChannelHandlerInvoker and Bootstrap are modified to complete
returned future only after the whole async operation is completed.

Result:
chaining async operations does not result in intermittent failures due to
premature access to channel, errors potentially appearing in later stages
of async operations are also properly reported through failure of the
future.
nayato added a commit that referenced this issue Feb 10, 2016
@nayato
Merge pull request #67 from nayato/fixfuture
21a8dc1 
Fixes premature completion of async operations (#66)
@nayato nayato closed this as completed Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nayato