Fixes premature completion of async operations (#66) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Due to misuse of IEventExecutor.SubmitAsync in DefaultChannelHandlerInvoker and Bootstrap, async operations return future that is completed after first sync part of operation is through. Modifications: DefaultChannelHandlerInvoker and Bootstrap are modified to complete returned future only after the whole async operation is completed. Result: chaining async operations does not result in intermittent failures due to premature access to channel, errors potentially appearing in later stages of async operations are also properly reported through failure of the future.
| @@ -34,6 +34,11 @@ public bool setUncancellable() | |||
| return true; | |||
| } | |||
|
|
|||
| public override string ToString() | |||
| { | |||
| return "TaskCompletionSource[status: " + this.Task.Status.ToString() + "]"; | |||
There was a problem hiding this comment.
- .ToString() is redundant, right? It should auto-convert based on inferring the '+' op
There was a problem hiding this comment.
it's Concat(string..) vs Concat(object..). I prefer to explicitly call ToString to avoid hidden boxing. In this case though, it'll get boxed anyway (Enum.ToString() issue) but this is for debugging / unhappy path logging only anyway.
|
lgtm |
nayato
added a commit
that referenced
this pull request
Feb 10, 2016
Fixes premature completion of async operations (#66)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due to misuse of IEventExecutor.SubmitAsync in
DefaultChannelHandlerInvoker and Bootstrap, async operations return future
that is completed after first sync part of operation is through.
Modifications:
DefaultChannelHandlerInvoker and Bootstrap are modified to complete
returned future only after the whole async operation is completed.
Result:
chaining async operations does not result in intermittent failures due to
premature access to channel, errors potentially appearing in later stages
of async operations are also properly reported through failure of the
future.