Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate code target to use new common scripts #3033

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented Jan 25, 2023

Description

Update to consume the new common location for the cadl scripts Azure/azure-sdk-tools#5231

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@m-nash m-nash marked this pull request as ready for review January 31, 2023 01:42
@chunyu3
Copy link
Member

chunyu3 commented Jan 31, 2023

Hello @m-nash There are two copies of Cadl-Project-Sync.ps1 and Cadl-Project-Generate.ps1, one is under eng\common\scipts, the other is under eng\scripts. Will we remove the copy under eng\scripts?

@m-nash
Copy link
Member Author

m-nash commented Jan 31, 2023

Hello @m-nash There are two copies of Cadl-Project-Sync.ps1 and Cadl-Project-Generate.ps1, one is under eng\common\scipts, the other is under eng\scripts. Will we remove the copy under eng\scripts?

Yes this will be updated after this build target change in this PR Azure/azure-sdk-for-net#33681

@archerzz
Copy link
Member

Looks like there is some azure core upstream changes we need to apply.

@m-nash m-nash enabled auto-merge (squash) January 31, 2023 02:20
@m-nash m-nash merged commit 52a33de into feature/v3 Jan 31, 2023
@m-nash m-nash deleted the mnash-commonScripts branch January 31, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants