Move cadl project scripts to common #5231

m-nash · 2023-01-25T23:14:01Z

No description provided.

azure-sdk · 2023-01-25T23:17:55Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2023-01-25T23:39:04Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

eng/common/scripts/Cadl-Project-Generate.ps1

weshaggard · 2023-01-25T23:43:24Z

eng/common/scripts/Cadl-Project-Generate.ps1

+$specSubDirectory = $configuration["directory"]
+$innerFolder = Split-Path $specSubDirectory -Leaf
+
+$tempFolder = "$ProjectDirectory/TempCadlFiles"


If there isn't a good reason to have the Temp folder in the same directory it would be nice come up with some other convention, maybe even the global temp folder.

If we keep it under the repo we will need to get it added to .gitignore in the other repos as well.

It is added to .gitignore and the advantage here is if you want to do some local changes / what if having it right next to your project is convenient

eng/common/scripts/Cadl-Project-Generate.ps1

eng/common/scripts/Cadl-Project-Sync.ps1

azure-sdk · 2023-01-26T16:24:12Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2023-01-26T18:06:23Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard

This looks like a good starting point. One thing we should try to figure out is how we test this when we make changes. We should try to write some test scripts that cover the scenarios so we can be sure we don't break things.

azure-sdk · 2023-01-30T19:10:06Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

ghost · 2023-01-30T20:45:19Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

move scripts to common

063a844

add reference to common script

de1581a

m-nash marked this pull request as ready for review January 25, 2023 23:35

m-nash requested review from sima-zhu, weshaggard and benbp as code owners January 25, 2023 23:35

weshaggard reviewed Jan 25, 2023

View reviewed changes

eng/common/scripts/Cadl-Project-Generate.ps1 Show resolved Hide resolved

weshaggard reviewed Jan 25, 2023

View reviewed changes

eng/common/scripts/Cadl-Project-Generate.ps1 Show resolved Hide resolved

weshaggard reviewed Jan 25, 2023

View reviewed changes

eng/common/scripts/Cadl-Project-Generate.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Jan 25, 2023

View reviewed changes

eng/common/scripts/Cadl-Project-Sync.ps1 Outdated Show resolved Hide resolved

address feedback

9273d02

m-nash added 2 commits January 26, 2023 09:57

couple tweaks to relative path updates

ccc7738

update copy paste issue with emitter path

8903ad9

weshaggard approved these changes Jan 26, 2023

View reviewed changes

updates to make scripts more generic

981c5e8

azure-sdk added the auto-merge label Jan 30, 2023

ghost merged commit 5299f7e into Azure:main Jan 30, 2023

m-nash mentioned this pull request Jan 31, 2023

Update generate code target to use new common scripts Azure/autorest.csharp#3033

Merged

6 tasks

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move cadl project scripts to common #5231

Move cadl project scripts to common #5231

m-nash commented Jan 25, 2023

azure-sdk commented Jan 25, 2023

azure-sdk commented Jan 25, 2023

weshaggard Jan 25, 2023

m-nash Jan 26, 2023

azure-sdk commented Jan 26, 2023

azure-sdk commented Jan 26, 2023

weshaggard left a comment

azure-sdk commented Jan 30, 2023

ghost commented Jan 30, 2023

Move cadl project scripts to common #5231

Move cadl project scripts to common #5231

Conversation

m-nash commented Jan 25, 2023

azure-sdk commented Jan 25, 2023

azure-sdk commented Jan 25, 2023

weshaggard Jan 25, 2023

Choose a reason for hiding this comment

m-nash Jan 26, 2023

Choose a reason for hiding this comment

azure-sdk commented Jan 26, 2023

azure-sdk commented Jan 26, 2023

weshaggard left a comment

Choose a reason for hiding this comment

azure-sdk commented Jan 30, 2023

ghost commented Jan 30, 2023

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.