Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s-configuration] Bump pycryptodome to support Python 3.10 #4643

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Apr 7, 2022

Fix Azure/azure-cli#21964

MSI's bundled Python has been updated to 3.10 (Azure/azure-cli#21746). k8s-configuration and connectedk8s depend on pycryptodome==3.9.8 which doesn't release wheels for Python 3.10:

https://pypi.org/project/pycryptodome/3.9.8/#files

image

The latest pycryptodome 3.14.1 works with Python 3.10 using ABIs:

https://pypi.org/project/pycryptodome/#files

image

@ghost ghost added Connected Kubernetes Auto-Assign Auto assign by bot labels Apr 7, 2022
@ghost ghost requested review from zhoxing-ms, jsntcy and yonzhan April 7, 2022 03:53
@ghost ghost assigned zhoxing-ms Apr 7, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 7, 2022
@ghost ghost requested a review from wangzelin007 April 7, 2022 03:53
@jiasli jiasli requested a review from sirireddy12 April 7, 2022 03:53
@@ -33,7 +33,7 @@
]

# TODO: Add any additional SDK dependencies here
DEPENDENCIES = ["pycryptodome~=3.9.8"]
DEPENDENCIES = ["pycryptodome~=3.14.1"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If k8sconfiguration is deprecated:

0.2.4
++++++++++++++++++
* Deprecate k8sconfiguration

We should remove it.

Copy link
Contributor

@zhoxing-ms zhoxing-ms Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, the description here should mean to deprecate/hide the k8sconfiguration command group and replace it with k8s-configuration command group.
PR link
Screenshot 2022-04-07 121818

@jonathan-innis Could please you confirm it? If so, please add specific information to the description to avoid ambiguity and confusion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, k8sconfiguration has been fully deprecated and we would like to remove it. @zhoxing-ms, do you want me to remove the extension? For this pycryptodome change, this change looks good and can be merged

Copy link
Contributor

@zhoxing-ms zhoxing-ms Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathan-innis OK, if you are sure that most users have been migrated from k8sconfiguration extension to k8s-configuration extension, please remove it.
In addition, the Build Event (May 24-26) is one of the window periods for CLI to launch batch breaking changes, which is a good opportunity for removing this extension

Copy link
Member Author

@jiasli jiasli Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only mean removing the source code. The released extension whls won't be deleted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the original extension is no longer used by users, I personally suggest that we can also consider removing them from index.json, so as to avoid too much contents in the index.json file

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 7, 2022

Bump pycryptodome

@jiasli jiasli changed the title [connectedk8s/k8s-configuration/k8sconfiguration] Bump pycryptodome to support Python 3.10 [connectedk8s/k8s-configuration] Bump pycryptodome to support Python 3.10 Apr 7, 2022
@jiasli
Copy link
Member Author

jiasli commented Apr 7, 2022

connectedk8s's pycryptodome has been bumped by #4607.

@jiasli jiasli changed the title [connectedk8s/k8s-configuration] Bump pycryptodome to support Python 3.10 [k8s-configuration] Bump pycryptodome to support Python 3.10 Apr 7, 2022
@jiasli jiasli requested review from jonathan-innis and removed request for sirireddy12 April 7, 2022 06:48
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants