-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packaging] Bump MSI embedded Python to 3.10.3 #21746
Conversation
REM Double colon :: should not be used in parentheses blocks, so we use REM. | ||
REM See https://stackoverflow.com/a/12407934/2199657 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using double colons in a block results in failure:
test.cmd
:
@echo off
SetLocal EnableDelayedExpansion
for /f %%f in ('dir /b /s *.pyc') do (
::echo test
::echo test
)
>test.cmd
The system cannot find the drive specified.
mkdir %PYTHON_DIR% | ||
pushd %PYTHON_DIR% | ||
echo Downloading Python. | ||
curl -o Python389-32.zip %PYTHON_DOWNLOAD_URL% -k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-k, --insecure
was introduced by #4523 allowing non-secure HTTPS, which we don't know why either.
REM Delete _pth file so that Lib\site-packages is included in sys.path | ||
REM https://github.com/pypa/pip/issues/4207#issuecomment-297396913 | ||
REM https://docs.python.org/3.10/using/windows.html#finding-modules | ||
del python*._pth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding python*._pth
, see:
Packaging related bug |
During my tests, even without this PR, I found edge build MSIs with the same version can be installed multiple times side by side for unknown reason: From the UI there is no way to tell which is which. For example, you may install these MSIs: |
Description
Fix #21734
#7633 says:
This PR switched from using Python from https://www.python.org/ftp/python/3.6.5/python-3.6.5-embed-win32.zip to https://azurecliprod.blob.core.windows.net/util/Python366-32.zip. We don't exactly know what the original ML extension problem is and why the change was made.
But according to our internal knowledge base,
Python366-32.zip
from the Storage Account is created followingEmbedded python are then brought back by
3.8.9
and remove more network SDK APIs for MSI #17816and we didn't receive any issue for ML extension.
This PR somehow reverts #7633 and installs embedded Python from official URL.