{Packaging/MSI} Use embeddable python for MSI #14300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fengzhou-msft
commented
Jul 22, 2020
| @@ -14,7 +14,7 @@ class AmsSpTests(ScenarioTest): | |||
| @StorageAccountPreparer(parameter_name='storage_account_for_create') | |||
| @AllowLargeResponse() | |||
| def test_ams_sp_create_reset(self, resource_group, storage_account_for_create): | |||
| with mock.patch('azure.cli.command_modules.ams._utils._gen_guid', side_effect=self.create_guid): | |||
| with mock.patch('azure.cli.command_modules.ams.operations.sp._gen_guid', side_effect=self.create_guid): | |||
There was a problem hiding this comment.
Follow Where to patch
fengzhou-msft
requested review from
arrownj,
haroldrandom,
jiasli,
Juliehzl,
mmyyrroonn and
qianwens
as code owners
fengzhou-msft
force-pushed
the
msi_reduce_size
branch
from
f7ff24f
to
745c56b
Compare
|
Packaging/MSI |
fengzhou-msft
force-pushed
the
msi_reduce_size
branch
from
745c56b
to
f709dc7
Compare
| @@ -13,3 +13,5 @@ | |||
| *.bat eol=crlf | |||
| # The az script for Git Bash/Cygwin should be LF | |||
| build_scripts/windows/scripts/az eol=lf | |||
| # sh scripts should be LF | |||
| *.sh eol=lf | |||
There was a problem hiding this comment.
why need this? Will git applicaiton get conflict with it?
There was a problem hiding this comment.
I would like to reuse the scripts/ci/build.sh to run on Git Bash. Without this setting, all files checked out on Windows will be converted to crlf and will have error when run with bash.
haroldrandom
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.