{RDBMS} Use ServicePrincipalCredential with environment credential
#22124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
|
RDBMS |
DaeunYim
approved these changes
Apr 20, 2022
evelyn-ys
approved these changes
Apr 21, 2022
jiasli
commented
Apr 21, 2022
|
|
||
| authority, _ = _get_authority_url( | ||
| # Override authority host if defined as env var | ||
| getenv(AZURE_AUTHORITY_HOST) or 'https://login.microsoftonline.com', |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#22009 relies on the latest
msal-extensions1.0.0, butazure-identitywill release a new version (Azure/azure-sdk-for-python#24083) as early as 2020-04-22. This will miss our 2022-04-20 code freeze deadline and 2022-04-22 release schedule for Apr 2022 sprint.rdbmsis the only module usingazure-identity. #4908 first uses env vars to createazure.common.credentials.ServicePrincipalCredentialsand passes the credential to client constructor. #17191 migrated to usingazure.identity.ClientSecretCredential.Since Azure CLI has migrated to MSAL (#19853),
rdbmscan now useServicePrincipalCredentialprovided byazure.cli.corewith environment credential.We will fully support environment credential in the future (#10241).
Testing Guide
Set env vars:
Run