Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting SDK to Direct 3.0.0.25-preview #136

Merged
merged 11 commits into from
Apr 23, 2019
Merged

Porting SDK to Direct 3.0.0.25-preview #136

merged 11 commits into from
Apr 23, 2019

Conversation

kirankumarkolli
Copy link
Member

Porting SDK to Direct 3.0.0.25-preview

@kirankumarkolli
1. Refreshing with latest V2 changes (ref commit: 4891ece95a18367e72b…
ac8c185 
…02aa0328d8c395dfa085e)

2. NoPartitionKeyValue inference moved to CosmosContainerSettings
3. ConnectionPolicy.Default made non-singleton
4. allowNonValueAggregateQuery: made configurable all the way
@kirankumarkolli
Enabling few more tests
c2f2396
@kirankumarkolli
Enabling few more tests
2498363
@kirankumarkolli
Merge remote-tracking branch 'origin/master' into users/kirankk/maste…
1a2f784 
…r_port

# Conflicts:
#	Microsoft.Azure.Cosmos/src/Resource/Container/CosmosContainerCore.cs
#	Microsoft.Azure.Cosmos/src/Resource/Settings/CosmosContainerSettings.cs
@kirankumarkolli
Addressing merge conflicts
32e0436
j82w
j82w approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to port the query logic to the cosmos query objects that were forked.

Microsoft.Azure.Cosmos/src/ClientRetryPolicy.cs Show resolved Hide resolved
Microsoft.Azure.Cosmos/src/Query/DefaultDocumentQueryExecutionContext.cs Show resolved Hide resolved
@kirankumarkolli
Copy link
Member Author

@bchong95 can you please take a look at query parts.

ealsur
ealsur previously approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to contain all the updated changes to Retry Policy 😄

j82w
j82w previously approved these changes Apr 22, 2019
View reviewed changes
@kirankumarkolli kirankumarkolli dismissed stale reviews from j82w and ealsur via 75d9a9b April 22, 2019 22:02
@kirankumarkolli kirankumarkolli merged commit c733644 into master Apr 23, 2019
@kirankumarkolli kirankumarkolli deleted the users/kirankk/master_port branch April 23, 2019 07:04
@j82w j82w mentioned this pull request Apr 26, 2019
Merged
@ElasticCoder ElasticCoder mentioned this pull request Jun 7, 2019
Closed
@mcpappas mcpappas mentioned this pull request Feb 28, 2020
Closed
@mcpappas mcpappas mentioned this pull request Mar 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@j82w j82w j82w approved these changes

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@bchong95 bchong95 Awaiting requested review from bchong95

@ausfeldt ausfeldt Awaiting requested review from ausfeldt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirankumarkolli @ealsur @j82w