Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MultiPolygon and PolygonCoordinates classes public. #1239

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Make MultiPolygon and PolygonCoordinates classes public. #1239

merged 2 commits into from
Mar 16, 2020

Conversation

mcpappas
Copy link
Contributor

@mcpappas mcpappas commented Mar 2, 2020

Description

Changed MultiPolygon and PolygonCoordinates back to public as I believe they were inadvertently reverted to internal as described in #1235. Related issues include #70, #79, and #136 (and of course #1235).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

Closes #1235.

@msftclas
Copy link

msftclas commented Mar 2, 2020

CLA assistant check
All CLA requirements met.

@j82w
Copy link
Contributor

j82w commented Mar 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

LalithaMV
LalithaMV previously approved these changes Mar 3, 2020
Copy link
Contributor

@LalithaMV LalithaMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support Point, LineString, Polygon and MultiPolygon. So cannot think of a reason why serialization classes for these types should be made internal. Making it public is right for these types.

@mcpappas
Copy link
Contributor Author

mcpappas commented Mar 4, 2020

azp /run

EDIT: Ah. Wasn't sure if I was allowed/supposed to kick it off on my own. I guess I have my answer. 😅

@j82w
Copy link
Contributor

j82w commented Mar 13, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mcpappas mcpappas requested a review from j82w March 16, 2020 21:26
@j82w j82w merged commit d3d3a22 into Azure:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiPolygon class marked internal after PR.
6 participants