Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk: Adds retry on RequestEntityTooLarge #2124

Merged
merged 8 commits into from
Jan 20, 2021
Merged

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Jan 14, 2021

When Bulk mode is turned on, and the user is using it for Read operations, it is possible to request a volume of documents which total size is larger than the 4Mb service limit.

In that case, the backend will return HTTP 200 for those operations within the boundary, but 413 for those that exceed it.

This PR adds the behavior of retrying those operations that exceed the boundary limit into another Bulk request.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

j82w
j82w previously approved these changes Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants