Porting spatial class from V2 to V3 , along with new MultiPolygon #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
kirankumarkolli and
kirillg
as code owners
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosSpatialTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosSpatialTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosSpatialTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
requested changes
Mar 19, 2019
kirankumarkolli
previously approved these changes
Mar 20, 2019
kirankumarkolli
approved these changes
Mar 20, 2019
kirillg
approved these changes
Mar 20, 2019
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will expose the Spatial classes which was internal in V3 sdk , writing CRUD test cases for
Polygon,LineString,Point, MultiPolygon.
Note: MultiPolygon is exposed to user for the first time in V3 , it was not exposed even in V2, and also our doc https://docs.microsoft.com/en-us/azure/cosmos-db/geospatial need to be updated after this PR.
This PR will partly complete the ask in issue #70.
MultiLineString will be still missing as it is not supported in backend yet .