Adding basic SQL virtual network rules functionality #4404

dnayantara · 2017-08-02T23:55:31Z

This PR adds the basic functionality of SQL virtual network rules. The nuget has been published in 1.6.0-preview. The SQL code has been updated to reference the new nuget package.

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Adding virtual network rules commands and tests

…nto preview

…ure-powershell into preview

…nto preview

Editing tests and updating session records

…nto preview

This reverts commit 630830b.

msftclas · 2017-08-02T23:55:35Z

@dnayantara,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

azuresdkci · 2017-08-03T00:00:08Z

Can one of the admins verify this patch?

cormacpayne · 2017-08-03T00:04:36Z

@azuresdkci add to whitelist

jaredmoo · 2017-08-02T23:59:58Z

src/ResourceManager/Sql/AzureRM.Sql.psd1

-               'New-AzureRmSqlSyncAgent', 'Get-AzureRmSqlSyncAgent', 
-               'Remove-AzureRmSqlSyncAgent', 'New-AzureRmSqlSyncAgentKey', 
-               'Get-AzureRmSqlSyncAgentLinkedDatabase'
+               'Switch-AzureRmSqlDatabaseFailoverGroup', 


intentional change? please undo to improve reviewability

jaredmoo · 2017-08-03T00:01:38Z

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/Common.ps1

+#>
+function Get-VirtualNetworkSubnetId ($vnetName)
+{
+	$vnetSubscriptionId = "d513e2e9-97db-40f6-8d1a-ab3b340cc81a"


this will make the test unrecordable, so I will not approve until the test is recordable. you can either import vnet cmdlets or directly use the vnet sdk

The networking team has removed their vnet cmdlets because of a naming change. So I cannot use their cmdlets. I will create a new task to re-record tests once their cmdlets are in. Would that be ok?

In that case you should be able to directly call the networking .net sdk from the test code

jaredmoo · 2017-08-03T00:07:08Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/NewAzureSqlServerVirtualNetworkRule.cs

+        [Parameter(Mandatory = true,
+            HelpMessage = "The Virtual Network Subnet Id that specifies the Microsoft.Network details")]
+        [ValidateNotNull]
+        public string VirtualNetworkSubnetId { get; set; }


This is open to debate but resource Id is IMO annoying to type, I would prefer to have another parameter set that has -VirtualNetworkSubnetName, -VirtualNetworkName, -VirtualNetworkResourceGroupName etc. The subnet's resource group can be optional, default to the same resource group as the sql server.

From the customer's perspective, they will get this entire id the minute they create the vnet using networking cmdlets. So it will be a copy paste for them. If we separate it out, they would have to manually separate out parts of the id and then pass it to us.

We discussed and it's fine as is, just wanted to make sure this was a conscious design choice by Nayantara.

jaredmoo · 2017-08-03T00:07:55Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/SetAzureSqlServerVirtualNetworkRule.cs

+        [Parameter(Mandatory = true,
+            HelpMessage = "The Virtual Network Subnet Id for the rule.")]
+        [ValidateNotNull]
+        public string VirtualNetworkSubnetId { get; set; }


Same comment about resource id as earlier.

jaredmoo · 2017-08-03T00:09:29Z

...ager/Sql/Commands.Sql/VirtualNetworkRule/Services/AzureSqlServerVirtualNetworkRuleAdapter.cs

+        {
+            AzureSqlServerVirtualNetworkRuleModel vnetFirewallRuleName = new AzureSqlServerVirtualNetworkRuleModel();
+
+            vnetFirewallRuleName.ResourceGroupName = resourceGroup;


minor style comment, low priority: I like to use object initializer syntax in cases like this

dnayantara · 2017-08-03T16:56:57Z

I will make the changes and then reopen the pull request

This reverts commit e04d6cb.

…re-powershell into preview

…nto preview

Adding fix for jenkins job

…nto preview

This reverts commit 8133016.

dnayantara · 2017-08-28T19:08:26Z

Reopening this pull request after addressing above comments and testing in production

msftclas · 2017-08-28T19:08:30Z

@dnayantara,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

jaredmoo

Just some minor comments. I only reviewed files under ResourceManager/Sql.

jaredmoo · 2017-08-28T19:13:36Z

src/ResourceManager/Sql/AzureRM.Sql.psd1

@@ -177,7 +177,11 @@ CmdletsToExport = 'Get-AzureRmSqlDatabaseTransparentDataEncryption',
               'Get-AzureRmSqlSyncMember', 'Remove-AzureRmSqlSyncMember', 
               'New-AzureRmSqlSyncAgent', 'Get-AzureRmSqlSyncAgent', 
               'Remove-AzureRmSqlSyncAgent', 'New-AzureRmSqlSyncAgentKey', 
-               'Get-AzureRmSqlSyncAgentLinkedDatabase'
+               'Get-AzureRmSqlSyncAgentLinkedDatabase',
+			   'New-AzureRmSqlServerVirtualNetworkRule',


nit: fix indentation here

jaredmoo · 2017-08-28T19:17:51Z

src/ResourceManager/Sql/Commands.Sql/Properties/Resources.resx

+    <value>Permanently removing Virtual Network Rule '{0}' for Azure Sql Server '{1}'</value>
+  </data>
+  <data name="RemoveAzureSqlServerVirtualNetworkRuleWarning" xml:space="preserve">
+    <value>Are you sure you want to remove the Virtual Network Rule '{0}' for Azure Sql Server  '{1}'?</value>


nit: 2 spaces just before '{1}'

jaredmoo · 2017-08-28T19:19:14Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/NewAzureSqlServerVirtualNetworkRule.cs

+            {
+                if (ex.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
+                {
+                    // This is what we want.  We looked and there is no server with this name.


nit: We looked and there is no virtual network rule with this name.

jaredmoo · 2017-08-28T19:20:58Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/NewAzureSqlServerVirtualNetworkRule.cs

+            {
+                ResourceGroupName = this.ResourceGroupName.Trim(),
+                ServerName = this.ServerName.Trim(),
+                VirtualNetworkRuleName = this.VirtualNetworkRuleName.Trim(),


is it standard to trim like this? I wonder if somebody does new-vnetrule -rulename "asdf " and then 'get-vnetrule -rulename "asdf " will they get the rule back? I mean I think Trim has to be done everywhere or nowhere.

Tested it. This is working the way it should.

akromm-zz · 2017-08-28T19:15:23Z

setup/azurecmdfiles.wxi

@@ -1556,9 +1556,6 @@
                        <Component Id="cmpC67F14F377421F1BCD74EC5A579D43CB" Guid="*">
                            <File Id="filE9553CEC1D67AB3D4B77759239D60B18" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.IotHub\Microsoft.Azure.Commands.IotHub.dll-Help.xml" />
                        </Component>
-                        <Component Id="cmpD844DA64698210481D550B5CD8799D26" Guid="*">
-                            <File Id="filA23D9B350E9B87D17B90B2181AE71E4B" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.IotHub\Microsoft.Azure.Commands.IotHub.format.ps1xml" />


Is this an intentional change?

This is a change to fix broken build. This change - #4503 removed a file, but this file was not updated.

akromm-zz · 2017-08-28T19:16:39Z

src/ResourceManager/Sql/AzureRM.Sql.psd1

@@ -177,7 +177,11 @@ CmdletsToExport = 'Get-AzureRmSqlDatabaseTransparentDataEncryption',
               'Get-AzureRmSqlSyncMember', 'Remove-AzureRmSqlSyncMember', 
               'New-AzureRmSqlSyncAgent', 'Get-AzureRmSqlSyncAgent', 
               'Remove-AzureRmSqlSyncAgent', 'New-AzureRmSqlSyncAgentKey', 
-               'Get-AzureRmSqlSyncAgentLinkedDatabase'
+               'Get-AzureRmSqlSyncAgentLinkedDatabase',
+			   'New-AzureRmSqlServerVirtualNetworkRule',


fix spacing (use spaces not tabs)

will make these changes

akromm-zz · 2017-08-28T19:18:19Z

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/VirtualNetworkRuleTest.ps1

+
+<#
+	.SYNOPSIS
+	Tests creating and updating a virtual network rule


Please be more specific.

akromm-zz · 2017-08-28T19:19:39Z

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/VirtualNetworkRuleTest.ps1

+	try
+	{
+		# Create rule
+		$virtualNetworkRule = New-AzureRmSqlServerVirtualNetworkRule -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -VirtualNetworkRuleName $virtualNetworkRuleName -VirtualNetworkSubnetId $virtualNetworkSubnetId1


please make these lines narrower to make it easier to review. You can use the ` character to have a command span multiple lines.

something like this would work?
New-AzureRmSqlServerVirtualNetworkRule -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName
` -VirtualNetworkRuleName $virtualNetworkRuleName -VirtualNetworkSubnetId $virtualNetworkSubnetId1

akromm-zz · 2017-08-28T19:20:45Z

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/VirtualNetworkRuleTest.ps1

+		$resp = Remove-AzureRmSqlServerVirtualNetworkRule -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -VirtualNetworkRuleName $virtualNetworkRuleName -Force
+		$all = Get-AzureRmSqlServerVirtualNetworkRule -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName
+		Assert-AreEqual $all.Count 0
+


remove unnecessary blank lines.

akromm-zz · 2017-08-28T19:28:02Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/SetAzureSqlServerVirtualNetworkRule.cs

+        [ValidateNotNull]
+        public string VirtualNetworkSubnetId { get; set; }
+
+


remove extra blank line. Look through all files.

akromm-zz · 2017-08-28T19:28:49Z

...ager/Sql/Commands.Sql/VirtualNetworkRule/Services/AzureSqlServerVirtualNetworkRuleAdapter.cs

+using System.Security;
+using System.Security.Permissions;
+using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions;


Please go through all .cs files and sort the usings and remove the ones not used.

akromm-zz · 2017-08-28T19:31:16Z

src/ResourceManager/Sql/Commands.Sql/help/New-AzureRmSqlServerVirtualNetworkRule.md

+```
+
+## DESCRIPTION
+This command creates an Azure SQL Server Virtual Network Rule.


Could you provide more detail describing what a "Azure SQL Server Virtual Network Rule" is or a link to MSDN?

We don't have an official MSDN yet. But I will provide more details

Oh! I edited the synopsis instead of the description. Will make that change with the next set of edits.

Updated in most recent commit

akromm-zz · 2017-08-28T19:32:05Z

src/ResourceManager/Sql/Commands.Sql/packages.config

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
  <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" />
-  <package id="Microsoft.Azure.Management.Sql" version="1.5.0-preview" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.Network" version="12.0.0-preview" targetFramework="net452" />


I didn't see where this was used. Please remove.

Our tests have a dependency on the Network team's cmdlets. Thus this has been added.

This is not the test package config. This is the config for the cmdlets.

Thats true. I assumed this was required in the commands project as well. I will try removing it and checking if it works.

akromm-zz · 2017-08-28T19:32:26Z

src/ServiceManagement/Common/Commands.ServiceManagement.Common/RequiredResourceLookup.cs

@@ -91,6 +91,11 @@ internal static IList<string> RequiredProvidersForResourceManager<T>()
                return new[] { StorageProviderNamespace };
            }

+            if (typeof(T).FullName.Equals("Microsoft.Azure.Management.Network.NetworkManagementClient"))


what is this for?

For creating and accessing the Network Management client.

This is in the ServiceManagement path/namespace. Is it used in the ResourceManager path/namespace?

Not exactly sure what you mean. Let me test it after removing it, probably I won't even need it.

dnayantara · 2017-08-28T21:47:57Z

Not sure why the build failed saying that the tests failed. They are passing in Playback mode for me. Record mode will fail right now as the cluster where these tests are being run is unavailable due to a DR Drill.

dnayantara · 2017-08-29T17:24:39Z

DR drill is now over. If you start another build, I would expect the tests to pass. I ran them once again on my machine,

cormacpayne · 2017-09-01T04:30:24Z

@azuresdkci test this please

cormacpayne · 2017-09-06T21:10:08Z

@akormm @jaredmoo would one of you mind signing off on the changes made by Nayantara? We are looking to shut down the public repository for Ignite and want to merge all PRs that are ready by the end of the day or we will re-open them in the private repository.

…verVirtualNetworkRule.md

kisantia · 2017-09-06T23:59:57Z

I addressed Adam's requested change. Jared signed off and Adam is OOF for a month. Is there anything else that needs to be done?

cormacpayne

@kisantia @jaredmoo please take a look at the comments when you get the chance.

We are shutting down the public repository for the Ignite release, so you should re-open this PR in the private repository. Here is a guide for migrating your PR from the public repository to the private repository: https://github.com/Azure/azure-powershell/wiki/Public-to-Private-Migration

cormacpayne · 2017-09-07T17:11:41Z

setup/azurecmdfiles.wxi

@@ -1556,9 +1556,6 @@
                        <Component Id="cmpC67F14F377421F1BCD74EC5A579D43CB" Guid="*">
                            <File Id="filE9553CEC1D67AB3D4B77759239D60B18" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.IotHub\Microsoft.Azure.Commands.IotHub.dll-Help.xml" />
                        </Component>
-                        <Component Id="cmpD844DA64698210481D550B5CD8799D26" Guid="*">


@kisantia pulling the latest changes from the preview branch will remove the need for this change

cormacpayne · 2017-09-07T17:12:31Z

...esourceManager/Common/Commands.ResourceManager.Common/Commands.ResourceManager.Common.csproj

@@ -50,6 +50,18 @@
    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
  </PropertyGroup>
  <ItemGroup>
+    <Reference Include="Microsoft.Azure.Management.Network, Version=14.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@kisantia this reference to the Network management library should be removed. Only the Network project should have a dependency on the management library. If you need to use the code from their library, please use the Commands.Common.Network project.

cormacpayne · 2017-09-07T17:14:05Z

src/ResourceManager/Common/Commands.ResourceManager.Common/packages.config

@@ -6,12 +6,13 @@
  <package id="Microsoft.Azure.Common" version="2.1.0" targetFramework="net452" />
  <package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net452" />
  <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net452" />
+  <package id="Microsoft.Azure.Management.Network" version="14.0.0-preview" targetFramework="net452" />


@kisantia same comment

cormacpayne · 2017-09-07T17:41:48Z

...sourceManager/Common/Commands.ScenarioTests.ResourceManager.Common/EnvironmentSetupHelper.cs

@@ -135,6 +135,15 @@ public string RMStorageDataPlaneModule
            }
        }

+        public string RMNetworkModule


@kisantia same comment

cormacpayne · 2017-09-07T17:43:04Z

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

@@ -82,10 +82,22 @@
      <HintPath>..\..\..\packages\Microsoft.Data.Services.Client.5.8.2\lib\net40\Microsoft.Data.Services.Client.dll</HintPath>
      <Private>True</Private>
    </Reference>
+    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">


@kisantia please revert the changes in this file. All changes to dependencies should be done in Common.Dependencies.targets and the packages.config in Commands.ResourceManager.Common.

cormacpayne · 2017-09-07T21:02:03Z

...Manager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/RemoveAzureSqlServerVirtualNetworkRule.cs

+        /// Defines whether it is ok to skip the requesting of rule removal confirmation
+        /// </summary>
+        [Parameter(HelpMessage = "Skip confirmation message for performing the action")]
+        public SwitchParameter Force { get; set; }


@kisantia this Force parameter should not be needed unless there is a special circumstance where you want to prompt the user to confirm their actions. I would take a look at Adam's comment below to see if this holds true.

cormacpayne · 2017-09-07T21:03:42Z

...Manager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/RemoveAzureSqlServerVirtualNetworkRule.cs

+    /// <summary>
+    /// Defines the Remove-AzureRmSqlServerVirtualNetworkRule cmdlet
+    /// </summary>
+    [Cmdlet(VerbsCommon.Remove, "AzureRmSqlServerVirtualNetworkRule", SupportsShouldProcess = true, ConfirmImpact = ConfirmImpact.Medium)]


@kisantia this cmdlet has no output type

cormacpayne · 2017-09-07T21:03:57Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/SetAzureSqlServerVirtualNetworkRule.cs

+    /// <summary>
+    /// Defines the Set-AzureRmSqlServerVirtualNetworkRule cmdlet
+    /// </summary>
+    [Cmdlet(VerbsCommon.Set, "AzureRmSqlServerVirtualNetworkRule",


@kisantia this cmdlet has no output type

cormacpayne · 2017-09-07T21:04:18Z

...rceManager/Sql/Commands.Sql/VirtualNetworkRule/Cmdlet/SetAzureSqlServerVirtualNetworkRule.cs

+    /// <summary>
+    /// Defines the Set-AzureRmSqlServerVirtualNetworkRule cmdlet
+    /// </summary>
+    [Cmdlet(VerbsCommon.Set, "AzureRmSqlServerVirtualNetworkRule",


@kisantia same comment about adding a parameter set with the VirtualNetworkRule object

cormacpayne · 2017-09-07T21:05:47Z

src/ResourceManager/Sql/Commands.Sql/help/Get-AzureRmSqlServerVirtualNetworkRule.md

+
+## OUTPUTS
+
+### System.Object


@kisantia the markdown help will need to be updated whenever you add the output attribute to each cmdlet

cormacpayne · 2017-09-11T16:22:55Z

Closing in favor of https://github.com/Azure/azure-powershell-pr/pull/278

NayantaraD added 10 commits July 7, 2017 22:33

Adding virtual network rules commands and tests

8677f51

Adding virtual network rules commands and tests

Adding VirtualNetworkRules to format.ps1xml file

b2cef3c

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

baa93a6

…nto preview

Merge branch 'privateacc' of https://github.com/EvgenyAgafonchikov/az…

057677f

…ure-powershell into preview

Adding the temporary fix for HelpAnalyzer.

630830b

Correcting minor build mistakes

eadc1a1

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

c5570fd

…nto preview

Editing tests and updating session records

3de79f6

Editing tests and updating session records

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

2171e87

…nto preview

Revert "Adding the temporary fix for HelpAnalyzer."

e04d6cb

This reverts commit 630830b.

dnayantara requested review from jaredmoo, cormacpayne and shahabhijeet August 2, 2017 23:55

msftclas added the cla-not-required label Aug 2, 2017

azuresdkci added the needs-review label Aug 3, 2017

azuresdkci assigned shahabhijeet Aug 3, 2017

jaredmoo suggested changes Aug 3, 2017

View reviewed changes

dnayantara closed this Aug 3, 2017

NayantaraD and others added 8 commits August 4, 2017 11:56

Editing tests and using Network's .Net SDK client

89993cc

Added service endpoints cmdlets

b370abc

Regenerated MD files, updated ChangeLog

b93ce59

Updated SDK version, updated recordings

4340077

Re-adding the temporary fix for HelpAnalyzer.""

8133016

This reverts commit e04d6cb.

Merge branch 'endpoints' of https://github.com/EvgenyAgafonchikov/azu…

3455f68

…re-powershell into preview

Fixing build bugs

c296abb

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

23506fd

…nto preview

NayantaraD added 5 commits August 22, 2017 14:27

Adding fix for jenkins job

9846cdb

Adding fix for jenkins job

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

d873129

…nto preview

Updating vnet tests and fixing build

a25c0d6

Revert "Re-adding the temporary fix for HelpAnalyzer."""

d3489f1

This reverts commit 8133016.

Undoing other changed files

1481cfc

dnayantara reopened this Aug 28, 2017

msftclas added the cla-not-required label Aug 28, 2017

jaredmoo previously approved these changes Aug 28, 2017

View reviewed changes

akromm-zz suggested changes Aug 28, 2017

View reviewed changes

Addressing Jared and Adam's comments

e8b91c0

dnayantara dismissed jaredmoo’s stale review via e8b91c0 August 28, 2017 21:49

added tests to csproj

9944439

markcowl assigned cormacpayne and unassigned shahabhijeet Sep 5, 2017

jaredmoo previously approved these changes Sep 6, 2017

View reviewed changes

Addressed Adam's comment on updating description in New-AzureRmSqlSer…

b1c0759

…verVirtualNetworkRule.md

kisantia dismissed jaredmoo’s stale review via b1c0759 September 6, 2017 22:16

cormacpayne suggested changes Sep 7, 2017

View reviewed changes

cormacpayne closed this Sep 11, 2017

		[ValidateNotNull]
		public string VirtualNetworkSubnetId { get; set; }

Adding basic SQL virtual network rules functionality #4404

Adding basic SQL virtual network rules functionality #4404

Conversation

dnayantara commented Aug 2, 2017 • edited Loading

Description

msftclas commented Aug 2, 2017

azuresdkci commented Aug 3, 2017

cormacpayne commented Aug 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredmoo Aug 3, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnayantara commented Aug 3, 2017

dnayantara commented Aug 28, 2017

msftclas commented Aug 28, 2017

jaredmoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnayantara Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnayantara Aug 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dnayantara commented Aug 28, 2017

dnayantara commented Aug 29, 2017

cormacpayne commented Sep 1, 2017

cormacpayne commented Sep 6, 2017

kisantia commented Sep 6, 2017

cormacpayne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cormacpayne commented Sep 11, 2017

dnayantara commented Aug 2, 2017 •

edited

Loading

jaredmoo Aug 3, 2017 •

edited

Loading

dnayantara Aug 28, 2017 •

edited

Loading

dnayantara Aug 28, 2017 •

edited

Loading