-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KeyVault ps1xml File from IoT Hub #4503
Conversation
@chieftn, |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chieftn one small comment, otherwise LGTM
@@ -63,7 +63,7 @@ RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; ModuleVersion = '3.2.1'; } | |||
# TypesToProcess = @() | |||
|
|||
# Format files (.ps1xml) to be loaded when importing this module | |||
FormatsToProcess = '.\Microsoft.Azure.Commands.IotHub.format.ps1xml' | |||
#FormatsToProcess = '.\Microsoft.Azure.Commands.IotHub.format.ps1xml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chieftn I would change this to
# FormatsToProcess = @()
for consistency across all empty/commented out attributes in this file
@cormacpayne -- thanks for the feedback -- updated psd to fit convention. |
Description
Removed Microsoft.Azure.Commands.IotHub.format.ps1xml and associated reference from psd. This document solely influenced the display of properties without adding additional methods. I therefore judged that no updates to documentation were applicable. If I am in error, I will happily correct. Thank you for your review!
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines