-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022 11 08 #22025
2022 11 08 #22025
Conversation
Hi, @mozansaka Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.2)] | new version | base version |
---|---|---|
postgresqlhsc.json | 2022-11-08(ceecd59) | 2020-10-05-privatepreview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSql/serverGroupsv2' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L76:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L118:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L334:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers/{serverName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L379:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers/{serverName}/configurations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L424:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/configurations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L472:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/configurations/{configurationName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L517:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/firewallRules/{firewallRuleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L618:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/firewallRules' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L772:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/roles/{roleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L817:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/roles' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L928:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/restart' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L973:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/start' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1016:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/stop' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1059:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSql/checkNameAvailability' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1102:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.DBForPostgreSql/operations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1147:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PostgreSQLVersion' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'CitusVersion' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerState' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerRoleGroupList' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroupForUpdate' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroupPropertiesForUpdate' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroup' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroupProperties' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroupConfiguration' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ServerGroupConfigurationProperties' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1674:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
1007 - RemovedClientParameter |
The new version is missing a client parameter that was found in the old version. Was 'ServerGroupNameParameter' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2897:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L2215:3 |
1023 - TypeFormatChanged |
The new version has a different format than the previous one. New: common-types/resource-management/v4/types.json#L625:5 Old: common-types/resource-management/v1/types.json#L551:5 |
1036 - ConstraintChanged |
The new version has a different 'pattern' value than the previous one. New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2909:5 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L2226:5 |
️⚠️
LintDiff: 19 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-2022-11-08 | package-2022-11-08(ceecd59) | default(dev-postgresqlhsc-Microsoft.DBforPostgreSQL-2022-11-08) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Clusters_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[201].schema' Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L119 |
||
'PUT' operation 'Configurations_UpdateCoordinator' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L586 |
||
'PUT' operation 'Configurations_UpdateNode' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L652 |
||
Operations with a 202 response should specify x-ms-long-running-operation: true .Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1467 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1842 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1846 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1868 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1891 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1978 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1988 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2010 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2033 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2107 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2111 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2129 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2152 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2258 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2381 |
||
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2397 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1705 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1709 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2581 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2605 |
|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2665 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @mozansaka, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @mozansaka, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @mozansaka, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
69328fe
into
Azure:dev-postgresqlhsc-Microsoft.DBforPostgreSQL-2022-11-08
…ersion stable/2022-11-08 (#22124) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08 * Updates readme * Updates API version in new specs and examples * empty commit (#21932) Co-authored-by: Ozan Saka <[email protected]> * 2022 11 08 (#22025) * Add private endpoint con. and private link endpoints * Add private link list example * Cluster related endpoint and exampled changes * Cluster changes and configuration updates * Long running operation header additions * Change server group to cluster * Add systemData to examples, fix private endpoint con. property * Fix private link resource name parameter * Fix INVALID_TYPE boolean given as strings * Update approve private endp. con. request body * Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST * Fix INVALID_TYPE * Fix ModelValidation Errors * Fix lint errors * Fix lint errors * Remove location from cluster examples * Update example details, fix common types * Update readme files, fix configuration example name * Fix SDK generation by removing wrong pageable tags * Update configuration response types, fix cluster name pattern * Update configuration example names * Readme changes and minor final state via fix * Fix indentation on suppression items * Update node count description, remove pec id * Update cluster examples * Style fix * Update description Co-authored-by: Ozan Saka <[email protected]> Co-authored-by: Sena Gungor <[email protected]> * Fix credscan password (#22127) Co-authored-by: Ozan Saka <[email protected]> * Add required parameters (#22244) * Add 200 resp. code to put&patch, change boolean to enum (#22290) * Add 200 resp. code to put&patch, change boolean to enum * Update 200 responses * Update 200 response schemas, enum casing * Update configuration put requests * Remove role no-op case * fix private endp con list error, remove 200 code from role example * Add coord/node config list endpoints * fix sdk errors * add 200 resp for configuration put requests * Update readme * Fix arm feedbacks (#22334) * Fix arm feedbacks * Add pointInTimeUTC * Update passwords and readme file * Update response codes to 201, address feedbacks (#22386) * Update response codes to 201 * Add server configuration get * Update password * Fix duplicate operation id * Update configuration example files * Update configuration example files * Fix credscan issue (#22389) * Fix PutRequestResponseScheme error (#22408) * Fix PutRequestResponseScheme error * Update readme file * Update x-ms-mutability * Update property description * Fix server properties (#22772) * Fix server properties --------- Co-authored-by: mozansaka <[email protected]> Co-authored-by: Ozan Saka <[email protected]>
…ersion stable/2022-11-08 (Azure#22124) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08 * Updates readme * Updates API version in new specs and examples * empty commit (Azure#21932) Co-authored-by: Ozan Saka <[email protected]> * 2022 11 08 (Azure#22025) * Add private endpoint con. and private link endpoints * Add private link list example * Cluster related endpoint and exampled changes * Cluster changes and configuration updates * Long running operation header additions * Change server group to cluster * Add systemData to examples, fix private endpoint con. property * Fix private link resource name parameter * Fix INVALID_TYPE boolean given as strings * Update approve private endp. con. request body * Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST * Fix INVALID_TYPE * Fix ModelValidation Errors * Fix lint errors * Fix lint errors * Remove location from cluster examples * Update example details, fix common types * Update readme files, fix configuration example name * Fix SDK generation by removing wrong pageable tags * Update configuration response types, fix cluster name pattern * Update configuration example names * Readme changes and minor final state via fix * Fix indentation on suppression items * Update node count description, remove pec id * Update cluster examples * Style fix * Update description Co-authored-by: Ozan Saka <[email protected]> Co-authored-by: Sena Gungor <[email protected]> * Fix credscan password (Azure#22127) Co-authored-by: Ozan Saka <[email protected]> * Add required parameters (Azure#22244) * Add 200 resp. code to put&patch, change boolean to enum (Azure#22290) * Add 200 resp. code to put&patch, change boolean to enum * Update 200 responses * Update 200 response schemas, enum casing * Update configuration put requests * Remove role no-op case * fix private endp con list error, remove 200 code from role example * Add coord/node config list endpoints * fix sdk errors * add 200 resp for configuration put requests * Update readme * Fix arm feedbacks (Azure#22334) * Fix arm feedbacks * Add pointInTimeUTC * Update passwords and readme file * Update response codes to 201, address feedbacks (Azure#22386) * Update response codes to 201 * Add server configuration get * Update password * Fix duplicate operation id * Update configuration example files * Update configuration example files * Fix credscan issue (Azure#22389) * Fix PutRequestResponseScheme error (Azure#22408) * Fix PutRequestResponseScheme error * Update readme file * Update x-ms-mutability * Update property description * Fix server properties (Azure#22772) * Fix server properties --------- Co-authored-by: mozansaka <[email protected]> Co-authored-by: Ozan Saka <[email protected]>
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.