Fix server properties #22772
Merged
Fix server properties #22772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @senatol Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| postgresqlhsc.json | 2022-11-08(90e17be) | 2020-10-05-privatepreview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSql/serverGroupsv2' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L37:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L76:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L118:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L334:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers/{serverName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L379:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/servers/{serverName}/configurations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L424:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/configurations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L472:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/configurations/{configurationName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L517:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/firewallRules/{firewallRuleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L618:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/firewallRules' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L772:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/roles/{roleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L817:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/roles' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L928:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/restart' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L973:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/start' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1016:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/serverGroupsv2/{serverGroupName}/stop' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1059:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSql/checkNameAvailability' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1102:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.DBForPostgreSql/operations' removed or restructured? Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1147:5 |
|
The new version is missing a definition that was found in the old version. Was 'PostgreSQLVersion' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'CitusVersion' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerState' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerRoleGroupList' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroupForUpdate' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroupPropertiesForUpdate' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroup' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroupProperties' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroupConfiguration' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a definition that was found in the old version. Was 'ServerGroupConfigurationProperties' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L1852:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L1184:3 |
|
The new version is missing a client parameter that was found in the old version. Was 'ServerGroupNameParameter' removed or renamed? New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2838:3 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L2215:3 |
|
The new version has a different format than the previous one. New: common-types/resource-management/v4/types.json#L625:5 Old: common-types/resource-management/v1/types.json#L551:5 |
|
The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.DBforPostgreSQL/stable/2022-11-08/postgresqlhsc.json#L2588:7 Old: Microsoft.DBforPostgreSQL/preview/2020-10-05-privatepreview/postgresqlhsc.json#L2012:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-11-08 | package-2022-11-08(90e17be) | package-2022-11-08(dev-postgresqlhsc-Microsoft.DBforPostgreSQL-2022-11-08) |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @senatol, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
mozansaka
approved these changes
Feb 23, 2023
This was referenced Feb 23, 2023
[AutoPR azure-resourcemanager-postgresqlhsc] Fix server properties
azure-sdk/azure-sdk-for-java#4074
Closed
mozansaka
approved these changes
Feb 23, 2023
senatol
merged commit 8fb4aad
into
Azure:dev-postgresqlhsc-Microsoft.DBforPostgreSQL-2022-11-08
live1206
pushed a commit
that referenced
this pull request
Feb 28, 2023
…ersion stable/2022-11-08 (#22124) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08 * Updates readme * Updates API version in new specs and examples * empty commit (#21932) Co-authored-by: Ozan Saka <[email protected]> * 2022 11 08 (#22025) * Add private endpoint con. and private link endpoints * Add private link list example * Cluster related endpoint and exampled changes * Cluster changes and configuration updates * Long running operation header additions * Change server group to cluster * Add systemData to examples, fix private endpoint con. property * Fix private link resource name parameter * Fix INVALID_TYPE boolean given as strings * Update approve private endp. con. request body * Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST * Fix INVALID_TYPE * Fix ModelValidation Errors * Fix lint errors * Fix lint errors * Remove location from cluster examples * Update example details, fix common types * Update readme files, fix configuration example name * Fix SDK generation by removing wrong pageable tags * Update configuration response types, fix cluster name pattern * Update configuration example names * Readme changes and minor final state via fix * Fix indentation on suppression items * Update node count description, remove pec id * Update cluster examples * Style fix * Update description Co-authored-by: Ozan Saka <[email protected]> Co-authored-by: Sena Gungor <[email protected]> * Fix credscan password (#22127) Co-authored-by: Ozan Saka <[email protected]> * Add required parameters (#22244) * Add 200 resp. code to put&patch, change boolean to enum (#22290) * Add 200 resp. code to put&patch, change boolean to enum * Update 200 responses * Update 200 response schemas, enum casing * Update configuration put requests * Remove role no-op case * fix private endp con list error, remove 200 code from role example * Add coord/node config list endpoints * fix sdk errors * add 200 resp for configuration put requests * Update readme * Fix arm feedbacks (#22334) * Fix arm feedbacks * Add pointInTimeUTC * Update passwords and readme file * Update response codes to 201, address feedbacks (#22386) * Update response codes to 201 * Add server configuration get * Update password * Fix duplicate operation id * Update configuration example files * Update configuration example files * Fix credscan issue (#22389) * Fix PutRequestResponseScheme error (#22408) * Fix PutRequestResponseScheme error * Update readme file * Update x-ms-mutability * Update property description * Fix server properties (#22772) * Fix server properties --------- Co-authored-by: mozansaka <[email protected]> Co-authored-by: Ozan Saka <[email protected]>
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
…ersion stable/2022-11-08 (Azure#22124) * Adds base for updating Microsoft.DBforPostgreSQL from version preview/2020-10-05-privatepreview to version 2022-11-08 * Updates readme * Updates API version in new specs and examples * empty commit (Azure#21932) Co-authored-by: Ozan Saka <[email protected]> * 2022 11 08 (Azure#22025) * Add private endpoint con. and private link endpoints * Add private link list example * Cluster related endpoint and exampled changes * Cluster changes and configuration updates * Long running operation header additions * Change server group to cluster * Add systemData to examples, fix private endpoint con. property * Fix private link resource name parameter * Fix INVALID_TYPE boolean given as strings * Update approve private endp. con. request body * Fix OBJECT_ADDITIONAL_PROPERTIES and READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST * Fix INVALID_TYPE * Fix ModelValidation Errors * Fix lint errors * Fix lint errors * Remove location from cluster examples * Update example details, fix common types * Update readme files, fix configuration example name * Fix SDK generation by removing wrong pageable tags * Update configuration response types, fix cluster name pattern * Update configuration example names * Readme changes and minor final state via fix * Fix indentation on suppression items * Update node count description, remove pec id * Update cluster examples * Style fix * Update description Co-authored-by: Ozan Saka <[email protected]> Co-authored-by: Sena Gungor <[email protected]> * Fix credscan password (Azure#22127) Co-authored-by: Ozan Saka <[email protected]> * Add required parameters (Azure#22244) * Add 200 resp. code to put&patch, change boolean to enum (Azure#22290) * Add 200 resp. code to put&patch, change boolean to enum * Update 200 responses * Update 200 response schemas, enum casing * Update configuration put requests * Remove role no-op case * fix private endp con list error, remove 200 code from role example * Add coord/node config list endpoints * fix sdk errors * add 200 resp for configuration put requests * Update readme * Fix arm feedbacks (Azure#22334) * Fix arm feedbacks * Add pointInTimeUTC * Update passwords and readme file * Update response codes to 201, address feedbacks (Azure#22386) * Update response codes to 201 * Add server configuration get * Update password * Fix duplicate operation id * Update configuration example files * Update configuration example files * Fix credscan issue (Azure#22389) * Fix PutRequestResponseScheme error (Azure#22408) * Fix PutRequestResponseScheme error * Update readme file * Update x-ms-mutability * Update property description * Fix server properties (Azure#22772) * Fix server properties --------- Co-authored-by: mozansaka <[email protected]> Co-authored-by: Ozan Saka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.