Add support for JSChallenge action in Application Gateway Web application Firewall #26149

ssevugan21 · 2023-10-10T00:09:36Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

openapi-pipeline-app · 2023-10-10T00:09:39Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-10-10T00:09:40Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
webapplicationfirewall.json	2023-06-01(78e5864)	2023-05-01(main)

️❌LintDiff: 6 Errors, 0 Warnings failed [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-06	package-2023-06(78e5864)	package-2023-06(release-network-Microsoft.Network-official-2023-06-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManager.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths'].*.^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 6: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnectivityConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerGroup.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerScopeConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerSecurityAdminConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 6: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 7: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L37
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L83
`❌` PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies/{policyName}' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L122
`❌` ResourceNameRestriction	The resource name parameter 'policyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L122
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L236
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L271
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L283
`❌` MissingTypeObject	The schema 'WebApplicationFirewallPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L295
`❌` TrackedResourcePatchOperation	Tracked resource 'WebApplicationFirewallPolicy' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L295
`❌` MissingTypeObject	The schema 'WebApplicationFirewallPolicyPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L315
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L325
`❌` MissingTypeObject	The schema 'WebApplicationFirewallPolicyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L385
`❌` MissingTypeObject	The schema 'ManagedRulesDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L403
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L409
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L416
`❌` MissingTypeObject	The schema 'PolicySettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L425
`❌` MissingTypeObject	The schema 'WebApplicationFirewallCustomRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L525
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L544
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L590
`❌` MissingTypeObject	The schema 'MatchVariable' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L638
`❌` MissingTypeObject	The schema 'MatchCondition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L668
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L676
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L780
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L800
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L854
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L874
`❌` MissingTypeObject	The schema 'OwaspCrsExclusionEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L896
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L942
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L49
⚠️ RequiredReadOnlySystemData	The response of operation:'WebApplicationFirewallPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L123

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-10T00:09:41Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Network.26.0.0.nupkg
- Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [View full logs] [Preview SDK Changes] Breaking Change Detected
- Azure.ResourceManager.Network.1.6.0-alpha.20231012.1.nupkg
```
info	[Changelog] Breaking Changes:
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-network [View full logs] [Preview SDK Changes]
- azure-mgmt-network-25.1.0.zip
- azure_mgmt_network-25.1.0-py3-none-any.whl
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ActionTypeJSChallenge` added to enum type `ActionType`
info	[Changelog] - New value `BastionHostSKUNameDeveloper` added to enum type `BastionHostSKUName`
info	[Changelog] - New value `FirewallPolicyIDPSSignatureDirectionFour`, `FirewallPolicyIDPSSignatureDirectionThree` added to enum type `FirewallPolicyIDPSSignatureDirection`
info	[Changelog] - New value `VirtualNetworkGatewaySKUNameErGwScale` added to enum type `VirtualNetworkGatewaySKUName`
info	[Changelog] - New value `VirtualNetworkGatewaySKUTierErGwScale` added to enum type `VirtualNetworkGatewaySKUTier`
info	[Changelog] - New value `WebApplicationFirewallActionJSChallenge` added to enum type `WebApplicationFirewallAction`
info	[Changelog] - New enum type `FirewallPolicyIntrusionDetectionProfileType` with values `FirewallPolicyIntrusionDetectionProfileTypeAdvanced`, `FirewallPolicyIntrusionDetectionProfileTypeBasic`, `FirewallPolicyIntrusionDetectionProfileTypeExtended`, `FirewallPolicyIntrusionDetectionProfileTypeStandard`
info	[Changelog] - New function `*ManagementClient.BeginDeleteBastionShareableLinkByToken(context.Context, string, string, BastionShareableLinkTokenListRequest, *ManagementClientBeginDeleteBastionShareableLinkByTokenOptions) (*runtime.Poller[ManagementClientDeleteBastionShareableLinkByTokenResponse], error)`
info	[Changelog] - New struct `BastionShareableLinkTokenListRequest`
info	[Changelog] - New field `HostNames` in struct `ApplicationGatewayListenerPropertiesFormat`
info	[Changelog] - New field `Profile` in struct `FirewallPolicyIntrusionDetection`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 17 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Preview SDK Changes]

azure-arm-network-32.3.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface BastionShareableLinkTokenListRequest
info	[Changelog]   - Added Interface DeleteBastionShareableLinkByTokenOptionalParams
info	[Changelog]   - Added Type Alias FirewallPolicyIntrusionDetectionProfileType
info	[Changelog]   - Interface ApplicationGatewayListener has a new optional parameter hostNames
info	[Changelog]   - Interface FirewallPolicyIntrusionDetection has a new optional parameter profile
info	[Changelog]   - Added Enum KnownFirewallPolicyIntrusionDetectionProfileType
info	[Changelog]   - Enum KnownActionType has a new value JSChallenge
info	[Changelog]   - Enum KnownBastionHostSkuName has a new value Developer
info	[Changelog]   - Enum KnownVirtualNetworkGatewaySkuName has a new value ErGwScale
info	[Changelog]   - Enum KnownVirtualNetworkGatewaySkuTier has a new value ErGwScale
info	[Changelog]   - Enum KnownWebApplicationFirewallAction has a new value JSChallenge

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from cf89918b754aab6e998d144935782e3e5b10989d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.network.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.network.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-10-10T00:09:42Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-network-generated	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

microsoft-github-policy-service · 2023-10-10T00:09:47Z

Thank you for your contribution ssevugan21! We will review the pull request and get back to you soon.

Joanna-Yang-Art · 2023-10-11T17:43:51Z

@ssevugan21 Please get your PR reviewed and merged by ARM team by NRP code freeze date 10/12. NRP won't help review any swagger PRs, ARM does

ssevugan21 · 2023-10-12T00:22:48Z

/pr RequestMerge

ssevugan21 · 2023-10-12T00:35:40Z

@ssevugan21 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree [company="{your company}"]

ssevugan21 · 2023-10-12T00:39:38Z

@ssevugan21 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree [company="Microsoft"]

ssevugan21 · 2023-10-12T00:40:23Z

@ssevugan21 the command you issued was incorrect. Please try again.

Examples are:
@microsoft-github-policy-service agree
and
@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Microsoft"

ssevugan21 · 2023-10-12T00:41:29Z

@ssevugan21 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
@microsoft-github-policy-service agree [company="Microsoft"]

@microsoft-github-policy-service agree company="Microsoft"

ms-zhenhua · 2023-10-12T01:44:58Z

/azp run

azure-pipelines · 2023-10-12T01:45:11Z

Azure Pipelines successfully started running 2 pipeline(s).

ssevugan21 · 2023-10-12T02:05:28Z

@Joanna-Yang-Art @rkmanda i see Swagger LintDiff check failing with errors not related to my PR commits.

* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (#25887) * Firewall Policy - IDPS profiles (#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (#25982) * added ergwscale support (#25969) * Fixed examples for gateway load balancer (#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <[email protected]> * [NVA] Internet Ingress Parameters (#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <[email protected]> Co-authored-by: Sijie Lin <[email protected]> Co-authored-by: anvrao1 <[email protected]> Co-authored-by: NiviShenker <[email protected]> Co-authored-by: gdhillon24 <[email protected]> Co-authored-by: aneeshakella-microsoft <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: ssevugan21 <[email protected]> Co-authored-by: Manas Chakka <[email protected]> Co-authored-by: Manas Chakka <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: rutuja-s <[email protected]>

ssevugan21 added 3 commits October 9, 2023 16:54

Add support for JSChallenge action

fe674c7

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

Update WafPolicyGet.json

efeb707

Update WafPolicyCreateOrUpdate.json

78e5864

ssevugan21 requested a review from Joanna-Yang-Art as a code owner October 10, 2023 00:09

openapi-assignment-bot bot assigned rkmanda Oct 10, 2023

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 10, 2023

azure-sdk mentioned this pull request Oct 10, 2023

[AutoPR sdk/resourcemanager/network/armnetwork] Add support for JSChallenge action in Application Gateway Web application Firewall azure-sdk/azure-sdk-for-go#7617

Closed

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 10, 2023

github-actions bot added the MergeRequested label Oct 12, 2023

ssevugan21 closed this Oct 12, 2023

ssevugan21 reopened this Oct 12, 2023

ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 12, 2023

rkmanda added the Approved-LintDiff label Oct 12, 2023

rkmanda approved these changes Oct 12, 2023

View reviewed changes

rkmanda merged commit 77dc103 into Azure:release-network-Microsoft.Network-official-2023-06-01 Oct 12, 2023
24 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for JSChallenge action in Application Gateway Web application Firewall #26149

Add support for JSChallenge action in Application Gateway Web application Firewall #26149

ssevugan21 commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

microsoft-github-policy-service bot commented Oct 10, 2023

Joanna-Yang-Art commented Oct 11, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ms-zhenhua commented Oct 12, 2023

azure-pipelines bot commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

Add support for JSChallenge action in Application Gateway Web application Firewall #26149

Add support for JSChallenge action in Application Gateway Web application Firewall #26149

Conversation

ssevugan21 commented Oct 10, 2023 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

openapi-pipeline-app bot commented Oct 10, 2023 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 10, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 10, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 10, 2023 • edited Loading

Generated ApiView

microsoft-github-policy-service bot commented Oct 10, 2023

Joanna-Yang-Art commented Oct 11, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ms-zhenhua commented Oct 12, 2023

azure-pipelines bot commented Oct 12, 2023

ssevugan21 commented Oct 12, 2023

ssevugan21 commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading

openapi-pipeline-app bot commented Oct 10, 2023 •

edited

Loading