Add support for JSChallenge action in Application Gateway Web application Firewall #26149
openapi-pipeline-app / Swagger LintDiff
completed
Oct 12, 2023 in 15m 45s
Swagger LintDiff failed
LintDiff: 34 Errors, 7 Warnings
The check status is neutral due to the check was suppressed by label Approved-LintDiff. If you have any question, pls contact [email protected]
View more details.
Details
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-06 | package-2023-06(78e5864) | package-2023-06(release-network-Microsoft.Network-official-2023-06-01) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManager.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerConnectivityConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerGroup.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerScopeConnection.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
|
FATAL
|
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/stable/2023-06-01/networkManagerSecurityAdminConfiguration.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 6: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 7: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/78e5864e41bbf739f589b3e227f905b87e67181e/#L1 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L37 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L83 |
PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/ApplicationGatewayWebApplicationFirewallPolicies/{policyName}' Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L122 |
ResourceNameRestriction |
The resource name parameter 'policyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L122 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L236 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L271 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L283 |
MissingTypeObject |
The schema 'WebApplicationFirewallPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L295 |
TrackedResourcePatchOperation |
Tracked resource 'WebApplicationFirewallPolicy' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L295 |
MissingTypeObject |
The schema 'WebApplicationFirewallPolicyPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L315 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L325 |
MissingTypeObject |
The schema 'WebApplicationFirewallPolicyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L385 |
MissingTypeObject |
The schema 'ManagedRulesDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L403 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L409 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L416 |
MissingTypeObject |
The schema 'PolicySettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L425 |
MissingTypeObject |
The schema 'WebApplicationFirewallCustomRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L525 |
IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L544 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L590 |
MissingTypeObject |
The schema 'MatchVariable' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L638 |
MissingTypeObject |
The schema 'MatchCondition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L668 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L676 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L780 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L800 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L854 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L874 |
MissingTypeObject |
The schema 'OwaspCrsExclusionEntry' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L896 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L942 |
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L49 |
|
The response of operation:'WebApplicationFirewallPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L123 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L134 |
|
The response of operation:'WebApplicationFirewallPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L172 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L183 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L247 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Network/stable/2023-06-01/webapplicationfirewall.json#L497 |
Loading