Add APIs to Get/Put/List shared key of vpn link connection for vwan VpnGateway #30074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
This was referenced Aug 5, 2024
shengliumsft
changed the title
AzureRestAPISpecReview
added
ARMReview
WaitForARMFeedback
rkmanda
reviewed
Aug 7, 2024
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/vpnGateways/{gatewayName}/vpnConnections/{connectionName}/vpnLinkConnections/{linkConnectionName}/sharedKeys": { | ||
| "get": { | ||
| "operationId": "VpnLinkConnections_GetAllSharedKeys", | ||
| "description": "Lists all shared keys of VpnLink connection specified.", |
There was a problem hiding this comment.
Make this a part of a new API version
There was a problem hiding this comment.
@rkmanda , 2024-03-01 is the latest API version for Microsoft.Network. Can we use 2024-03-01 for our APIs?
There was a problem hiding this comment.
@rkmanda, I understand your concern about breaking change on this version (2024-03-01). The manifest rollout may already be completed, allowing users to use this version in production. Unfortunately, we cannot control the swagger release process, since NRP team is driving the release. But, this issue does not seem to be specific to our PR. Technically, any change in the 2024-03-01 Swagger release PR might be considered a breaking change, right? Also, our new APIs do not have public documentation yet, so users are not aware of them. Can you please help us work out a plan? I am happy to jump on a call. Thanks!
rkmanda
reviewed
Aug 7, 2024
specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/virtualWan.json
Show resolved
Hide resolved
rkmanda
reviewed
Aug 7, 2024
specification/network/resource-manager/Microsoft.Network/stable/2024-03-01/virtualWan.json
Show resolved
Hide resolved
shengliumsft
force-pushed
the
liusheng/vwanvpngatewaysharedkey_newapi
branch
2 times, most recently
from
3a616e0
to
3e081e2
Compare
rkmanda
added
Approved-Suppression
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
rkmanda
merged commit 3d6e80e
into
Azure:guptavertika/release-network-Microsoft.Network-2024-03-01
21 of 27 checks passed
dtuCloud
pushed a commit
to dtuCloud/azure-rest-api-specs
that referenced
this pull request
Aug 26, 2024
…pnGateway (Azure#30074) * first commit * run prettier * fix checks * fix checks * resolve comments * suppress error
GuptaVertika
pushed a commit
that referenced
this pull request
Sep 10, 2024
…pnGateway (#30074) * first commit * run prettier * fix checks * fix checks * resolve comments * suppress error
jaskisin
pushed a commit
to jaskisin/azure-rest-api-specs
that referenced
this pull request
Sep 16, 2024
…pnGateway (Azure#30074) * first commit * run prettier * fix checks * fix checks * resolve comments * suppress error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.