[AKS] Rename to "Operation" from "ComputeOperation" #3179

mboersma · 2018-06-04T17:14:24Z

Cleaning up a set of names that were copy-and-pasted from the Compute package. Not the end of the world, but it would be great if this could be merged before this new API is published in the Python SDK.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-06-04T17:15:27Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2186

AutorestCI · 2018-06-04T17:16:37Z

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#174

AutorestCI · 2018-06-04T17:16:38Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2848

AutorestCI · 2018-06-04T17:18:54Z

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpwiau93kn/rest/specification/containerservices/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpwiau93kn/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '[email protected]/autorest.go@~2.1.100', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.100)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-09"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Process() cancelled due to exception : '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).
Failure during batch task - {"tag":"package-2017-09"} -- Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
)..
  Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
  -
  VNet SubnetID specifies the vnet's subnet identifier. If you specify either
  master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
  have to be in the same VNet.
).

AutorestCI · 2018-06-04T17:21:31Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

dsgouda · 2018-06-04T18:22:32Z

...rservices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json

      "properties": {
        "value": {
          "type": "array",
          "readOnly": true,
          "items": {
-            "$ref": "#/definitions/ComputeOperationValue"
+            "$ref": "#/definitions/OperationValue"


Please acknowledge that this could be a breaking change to the generated sdk.

Yes, this change isn't backward-compatible. If we think that's problematic, this isn't crucial to merge.

But I don't think the 4.0.0 ACS SDK in #3131 has merged any of the generated PRs yet, so I'm hoping we can sneak this fix in without breaking anything.

* Add SDK Generation Options for new API Version (#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <[email protected]> Co-authored-by: Nate Lehman <[email protected]>

…italTwins-2021-06-30-preview-merge-with-main' (#17186) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (#3404) * Add SDK Generation Options for new API Version (#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <[email protected]> Co-authored-by: Nate Lehman <[email protected]> * Align with repo (#5658) Co-authored-by: Nate Lehman <[email protected]> Co-authored-by: Nate Lehman <[email protected]>

…italTwins-2021-06-30-preview-merge-with-main' (Azure#17186) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (Azure#3404) * Add SDK Generation Options for new API Version (Azure#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (Azure#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (Azure#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <[email protected]> Co-authored-by: Nate Lehman <[email protected]> * Align with repo (Azure#5658) Co-authored-by: Nate Lehman <[email protected]> Co-authored-by: Nate Lehman <[email protected]>

Rename to "Operation" from "ComputeOperation"

33469ca

sarangan12 added the review label Jun 4, 2018

AutorestCI mentioned this pull request Jun 4, 2018

[AutoPR containerservices/resource-manager] Rename to "Operation" from "ComputeOperation" Azure/azure-sdk-for-python#2684

Merged

azuresdkci assigned dsgouda Jun 4, 2018

azuresdkci requested a review from dsgouda June 4, 2018 17:15

This was referenced Jun 4, 2018

[AutoPR containerservices/resource-manager] Rename to "Operation" from "ComputeOperation" AutorestCI/azure-libraries-for-java#222

Merged

[AutoPR containerservices/resource-manager] Rename to "Operation" from "ComputeOperation" Azure/azure-sdk-for-node#2941

Merged

mboersma changed the title ~~Rename to "Operation" from "ComputeOperation"~~ [AKS] Rename to "Operation" from "ComputeOperation" Jun 4, 2018

dsgouda reviewed Jun 4, 2018

View reviewed changes

dsgouda approved these changes Jun 4, 2018

View reviewed changes

dsgouda merged commit 5929767 into Azure:master Jun 4, 2018

sarangan12 removed the review label Jun 4, 2018

mboersma deleted the rename-aks-operations-classes branch June 4, 2018 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS] Rename to "Operation" from "ComputeOperation" #3179

[AKS] Rename to "Operation" from "ComputeOperation" #3179

mboersma commented Jun 4, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

dsgouda Jun 4, 2018

mboersma Jun 4, 2018 •

edited

Loading

[AKS] Rename to "Operation" from "ComputeOperation" #3179

[AKS] Rename to "Operation" from "ComputeOperation" #3179

Conversation

mboersma commented Jun 4, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented Jun 4, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 4, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Jun 4, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Jun 4, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 4, 2018 • edited Loading

Automation for azure-sdk-for-ruby

dsgouda Jun 4, 2018

Choose a reason for hiding this comment

mboersma Jun 4, 2018 • edited Loading

Choose a reason for hiding this comment

mboersma commented Jun 4, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

AutorestCI commented Jun 4, 2018 •

edited

Loading

mboersma Jun 4, 2018 •

edited

Loading