Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AKS] Rename to "Operation" from "ComputeOperation" #3179

Merged
merged 1 commit into from
Jun 4, 2018
Merged

[AKS] Rename to "Operation" from "ComputeOperation" #3179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...rvices/resource-manager/Microsoft.ContainerService/stable/2018-03-31/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ComputeOperationListResult"
"$ref": "#/definitions/OperationListResult"
}
}
},
Expand Down Expand Up @@ -381,20 +381,20 @@
}
},
"definitions": {
"ComputeOperationListResult": {
"OperationListResult": {
"properties": {
"value": {
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/ComputeOperationValue"
"$ref": "#/definitions/OperationValue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please acknowledge that this could be a breaking change to the generated sdk.

Copy link
Member Author

@mboersma mboersma Jun 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change isn't backward-compatible. If we think that's problematic, this isn't crucial to merge.

But I don't think the 4.0.0 ACS SDK in #3131 has merged any of the generated PRs yet, so I'm hoping we can sneak this fix in without breaking anything.

},
"description": "The list of compute operations"
}
},
"description": "The List Compute Operation operation response."
},
"ComputeOperationValue": {
"OperationValue": {
"properties": {
"origin": {
"type": "string",
Expand All @@ -408,13 +408,13 @@
},
"display": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/ComputeOperationValueDisplay",
"$ref": "#/definitions/OperationValueDisplay",
"description": "Describes the properties of a Compute Operation Value Display."
}
},
"description": "Describes the properties of a Compute Operation value."
},
"ComputeOperationValueDisplay": {
"OperationValueDisplay": {
"properties": {
"operation": {
"type": "string",
Expand Down