Merge Network release branch into master #5184

anton-evseev · 2019-02-11T13:39:29Z

Required two other PRs to get merged first:

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…01 to version 2018-12-01

* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01

…s under applicationGatewayProperties (#5009)

* Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property

…ags (#5112)

* Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples

anton-evseev · 2019-02-11T13:42:49Z

@MikhailTryakhov please resolved merge conflicts, I don't have write access

azuresdkci · 2019-02-11T13:42:58Z

Can one of the admins verify this patch?

AutorestCI · 2019-02-11T13:45:43Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1174

AutorestCI · 2019-02-11T13:48:00Z

Automation for azure-sdk-for-ruby

A PR has been created for you:
Azure/azure-sdk-for-ruby#2216

AutorestCI · 2019-02-11T13:55:05Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4341

AutorestCI · 2019-02-11T14:05:05Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#4062

AutorestCI · 2019-02-11T14:30:22Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4665

AutorestCI · 2019-02-11T14:53:25Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', branch_name, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

* Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01

* Threat Intel changes for Azure Firewall * Move the property to the end of the list

...ation/network/resource-manager/Microsoft.Network/stable/2018-12-01/vmssNetworkInterface.json

nschonni · 2019-02-12T02:24:36Z

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualWan.json

+            "description": "The name of the gateway."
+          },
+          {
+            "$


provisisoning -> provisioning

nschonni · 2019-02-12T02:25:06Z

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualWan.json

+            "description": "The name of the gateway."
+          },
+          {
+            "$


double word "for"

nschonni · 2019-02-12T02:25:40Z

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualWan.json

+            "description": "The name of the gateway."
+          },
+          {
+            "$


vpnclients -> VPN clients'

nschonni · 2019-02-12T02:26:39Z

specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/virtualWan.json

+            "$ref": "./examples/VpnSiteGet.json"
+          }
+        },
+        "description": "Retrieves the details of a VPNsite.",


VPNsite -> VPN site

nschonni · 2019-02-12T02:43:41Z

...etwork/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCrossConnection.json

+        ],
+        "responses": {
+          "200": {
+            "description": "Request successful. The operation returns a list of ExpressRouteCrossConnection resources. If there are no crossconnection resources an empty list is returned.",


crossconnection -> cross connection

nschonni · 2019-02-12T02:44:21Z

...etwork/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCrossConnection.json

+        ],
+        "responses": {
+          "200": {
+            "description": "Request successful.The operation returns a list of ExpressRouteCrossConnection resources. If there are no crossconnection resources an empty list is returned.",


crossconnection -> cross connection

nschonni · 2019-02-12T02:45:27Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCircuit.json

+        ],
+        "responses": {
+          "200": {
+            "description": "Request successful. The operation returns a list of ExpressRouteServiceProdiver resources.",


ExpressRouteServiceProdiver -> ExpressRouteServiceProvider

nschonni · 2019-02-12T02:45:51Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCircuit.json

+          "items": {
+            "type": "string"
+          },
+          "description": "The communities of bgp peering. Spepcified for microsoft peering"


Spepcified -> Specified

nschonni · 2019-02-12T02:46:39Z

...cation/network/resource-manager/Microsoft.Network/stable/2018-12-01/expressRouteCircuit.json

+        "provisioningState": {
+          "type": "string",
+          "readOnly": true,
+          "description": "Provisioning state of the circuit connection resource. Possible values are: 'Succeded', 'Updating', 'Deleting', and 'Failed'."


Succeded -> Succeeded as long as the typo isn't in the enum

SDK code seems to override this prop with the one inherited from SubResource
https://github.com/Azure/azure-sdk-for-net/blob/master/src/SDKs/Network/Management.Network/Generated/Models/ExpressRouteCircuitConnection.cs#L52
I'll double check what the server returns

anton-evseev · 2019-02-12T09:15:04Z

Closing in favor of #5189

MikhailTryakhov and others added 15 commits January 3, 2019 16:49

Adds base for updating Microsoft.Network from version stable/2018-11-…

25d3409

…01 to version 2018-12-01

Updates readme

fb9564f

Updates API version in new specs and examples

cd3fe9f

fixing invalid paths in frontdoor (#4991)

3ec98c8

add max bound for application gateway autoscale config (#4996)

4906929

fixing location in network samples (#4992)

3fcc923

Fix duplicate path in old Network API versions (#5003)

7da6f1d

missing location in route tables (#5024)

e4158c5

removed confusing readonly parameters from example (#5022)

7be29f9

Fix errors in ddosCustomPolicy.json (#5013)

9d588c8

* Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01

Pick AppGw changes from 2018-11-01 (#5044)

f26cb6d

Adding the structure of ruleSequence and conditions in rewriteRuleSet…

c8027f9

…s under applicationGatewayProperties (#5009)

Added Prepare action for subnet (#5058)

3ded879

* Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property

updated the destination address description to also include service t…

598f0e7

…ags (#5112)

anton-evseev requested a review from MikhailTryakhov as a code owner February 11, 2019 13:39

azuresdkci assigned dsgouda Feb 11, 2019

azuresdkci requested a review from dsgouda February 11, 2019 13:41

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR network/resource-manager/frontdoor/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-js#1174

Closed

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR network/resource-manager/frontdoor/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-ruby#2216

Closed

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR network/resource-manager/frontdoor/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-python#4341

Closed

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR network/resource-manager/frontdoor/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-go#4062

Closed

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR network/resource-manager/frontdoor/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-node#4665

Closed

AutorestCI mentioned this pull request Feb 11, 2019

[AutoPR frontdoor/resource-manager/network/resource-manager] Merge Network release branch into master Azure/azure-sdk-for-java#2935

Closed

Fixed issue: #4721 (#5087)

c0f9183

* Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01

dsgouda added the Reassign label Feb 11, 2019

azuresdkci removed the Reassign label Feb 11, 2019

azuresdkci assigned sergey-shandar and unassigned dsgouda Feb 11, 2019

azuresdkci requested a review from sergey-shandar February 11, 2019 17:06

Threat Intel changes for Azure Firewall (#5143)

b616d58

* Threat Intel changes for Azure Firewall * Move the property to the end of the list

nschonni reviewed Feb 12, 2019

View reviewed changes

anton-evseev closed this Feb 12, 2019

sergey-shandar deleted the network-january-release branch April 19, 2019 22:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge Network release branch into master #5184

Merge Network release branch into master #5184

anton-evseev commented Feb 11, 2019

anton-evseev commented Feb 11, 2019

azuresdkci commented Feb 11, 2019

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

nschonni Feb 12, 2019

anton-evseev Feb 12, 2019

anton-evseev commented Feb 12, 2019

Merge Network release branch into master #5184

Merge Network release branch into master #5184

Conversation

anton-evseev commented Feb 11, 2019

Contribution checklist:

ARM API Review Checklist

anton-evseev commented Feb 11, 2019

azuresdkci commented Feb 11, 2019

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anton-evseev commented Feb 12, 2019

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading