-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-javaEncountered a Subprocess error: (azure-sdk-for-java)
Command: ['/usr/local/bin/autorest', '/tmp/tmpdid1vabq/rest/specification/datamigration/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpfol95tqs'] AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
at main (/opt/node_modules/autorest/dist/app.js:232:19)
at <anonymous>
/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
autorest_core_1.Shutdown();
^
ReferenceError: autorest_core_1 is not defined
at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
at emitOne (events.js:121:20)
at process.emit (events.js:211:7)
at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
return binding.close(fd);
^
Error: EBADF: bad file descriptor, close
at Object.fs.closeSync (fs.js:612:18)
at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
at process._fatalException (bootstrap_node.js:391:26) |
Can one of the admins verify this patch? |
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
Automation for azure-sdk-for-netA PR has been created for you: |
...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json
Show resolved
Hide resolved
...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json
Show resolved
Hide resolved
...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json
Show resolved
Hide resolved
...er/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/ServiceFeatureOCITask.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part left a couple of comments.
SInce these are not ARM resource operations, we can skip the review
...er/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/ServiceFeatureOCITask.json
Show resolved
Hide resolved
...er/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/ServiceFeatureOCITask.json
Outdated
Show resolved
Hide resolved
...n/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Tasks.json
Outdated
Show resolved
Hide resolved
Does anyone know how I can find what the error in the automated public.rest-api-specs failure is? I looked at the log but don't see anything wrong in the json. I ran the file through a validator and it seems to be correct too. The error is "Path 'paths['/subscriptions/{subscriptionId}/resourceGroups/{groupName}/providers/Microsoft.DataMigration/services/{serviceName}'].parameters', line 130, position 21." Cannot deserialize the current JSON array. It seems to be complaining about the parameters for that path but the line number doesn't make sense. The parameters field is on line 107 and seems to formatted correctly. |
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
@sarangan12 @sergey-shandar could you please take a look at the failures here |
431a6fc
to
5c209c2
Compare
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
@dsgouda could you reaise a bug for the diff tool https://github.com/Azure/openapi-diff/issues ? |
@sergey-shandar I have approved the PR, if the build failures are bugs, please merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…k resource which supports the scenario.
I've added back all my original changes. I'm ready for merging other than the one failing test which we can't figure out. Thank you for the help looking into this. |
REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit
Hello, I'm wondering if we could get eyes on this. There are some Powershell and CLI deliverables that are backed up behind this. Thanks! |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.