Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801

huang91shu · 2019-04-30T06:18:53Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-30T06:19:42Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-04-30T06:20:00Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5417

AutorestCI · 2019-04-30T06:22:52Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4897

AutorestCI · 2019-04-30T06:23:20Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI · 2019-04-30T06:24:19Z

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpdid1vabq/rest/specification/datamigration/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpfol95tqs']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

azuresdkci · 2019-04-30T07:01:34Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

adxsdknet · 2019-04-30T07:08:35Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6002
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@47e8f95
adxsdknet/azure-sdk-for-net@32b7f34
adxsdknet/azure-sdk-for-net@54cedac
adxsdknet/azure-sdk-for-net@3cf6bf1
adxsdknet/azure-sdk-for-net@8fc5e2f
adxsdknet/azure-sdk-for-net@ac10932
adxsdknet/azure-sdk-for-net@03f9c24

...ation/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/datamigration.json

...er/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/ServiceFeatureOCITask.json

dsgouda

Looks good for the most part left a couple of comments.
SInce these are not ARM resource operations, we can skip the review

...er/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/ServiceFeatureOCITask.json

...n/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Tasks.json

huang91shu · 2019-04-30T20:59:02Z

Does anyone know how I can find what the error in the automated public.rest-api-specs failure is? I looked at the log but don't see anything wrong in the json. I ran the file through a validator and it seems to be correct too.

The error is "Path 'paths['/subscriptions/{subscriptionId}/resourceGroups/{groupName}/providers/Microsoft.DataMigration/services/{serviceName}'].parameters', line 130, position 21." Cannot deserialize the current JSON array.

It seems to be complaining about the parameters for that path but the line number doesn't make sense. The parameters field is on line 107 and seems to formatted correctly.

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

dsgouda · 2019-05-16T21:27:00Z

@sarangan12 @sergey-shandar could you please take a look at the failures here

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

sergey-shandar · 2019-05-23T18:22:29Z

@dsgouda could you reaise a bug for the diff tool https://github.com/Azure/openapi-diff/issues ?

dsgouda · 2019-05-23T20:32:50Z

@sergey-shandar I have approved the PR, if the build failures are bugs, please merge this

dsgouda

LGTM

…k resource which supports the scenario.

huang91shu · 2019-05-28T18:27:32Z

I've added back all my original changes. I'm ready for merging other than the one failing test which we can't figure out. Thank you for the help looking into this.

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

vchske · 2019-05-29T17:52:54Z

Hello, I'm wondering if we could get eyes on this. There are some Powershell and CLI deliverables that are backed up behind this. Thanks!

huang91shu requested review from ash1625, hitenjava, haitsongmsft and binuj April 30, 2019 06:18

AutorestCI mentioned this pull request Apr 30, 2019

[AutoPR datamigration/resource-manager] Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource Azure/azure-sdk-for-python#4987

Closed

AutorestCI mentioned this pull request Apr 30, 2019

[AutoPR datamigration/resource-manager] Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource Azure/azure-sdk-for-go#4704

Merged

AutorestCI mentioned this pull request Apr 30, 2019

[AutoPR datamigration/resource-manager] Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource Azure/azure-sdk-for-java#3483

Closed

huang91shu force-pushed the master branch from 5434695 to 2a5dd49 Compare April 30, 2019 06:46

azuresdkci assigned dsgouda Apr 30, 2019

azuresdkci requested a review from dsgouda April 30, 2019 06:52

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 30, 2019

.NET SDK Resource Provider:'DataMigration'

47e8f95

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

dsgouda suggested changes Apr 30, 2019

View reviewed changes

dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2019

dsgouda suggested changes Apr 30, 2019

View reviewed changes

dsgouda removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2019

huang91shu force-pushed the master branch from 2a5dd49 to 33645c3 Compare April 30, 2019 20:59

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 30, 2019

.NET SDK Resource Provider:'DataMigration'

32b7f34

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

huang91shu force-pushed the master branch from 33645c3 to 7b7920d Compare May 16, 2019 19:02

huang91shu force-pushed the master branch 3 times, most recently from 431a6fc to 5c209c2 Compare May 22, 2019 23:58

AutorestCI mentioned this pull request May 23, 2019

[AutoPR datamigration/resource-manager] Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource Azure/azure-sdk-for-python#5434

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'DataMigration'

54cedac

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

huang91shu force-pushed the master branch from 5c209c2 to 96de385 Compare May 23, 2019 00:41

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'DataMigration'

3cf6bf1

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

huang91shu force-pushed the master branch from 96de385 to a455f45 Compare May 23, 2019 00:53

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'DataMigration'

8fc5e2f

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

huang91shu force-pushed the master branch from a455f45 to 2281cc3 Compare May 23, 2019 01:09

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 23, 2019

.NET SDK Resource Provider:'DataMigration'

ac10932

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

dsgouda approved these changes May 23, 2019

View reviewed changes

Add Oracle to Azure Database For PostgreSQL scenarios and Service Tas…

e940366

…k resource which supports the scenario.

huang91shu force-pushed the master branch from 2281cc3 to e940366 Compare May 28, 2019 18:26

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 28, 2019

.NET SDK Resource Provider:'DataMigration'

03f9c24

REST Spec PR 'Azure/azure-rest-api-specs#5801' REST Spec PR Author 'huang91shu' REST Spec PR Last commit

sergey-shandar merged commit 1afa17d into Azure:master May 29, 2019

vchske mentioned this pull request Jun 4, 2019

[AutoPR] datamigration/resource-manager Azure/azure-sdk-for-python#5417

Merged

nschonni mentioned this pull request Jun 14, 2019

chore: jsonfmt datamigration #6324

Merged

vchske mentioned this pull request Jul 2, 2019

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801

Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801

huang91shu commented Apr 30, 2019

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

azuresdkci commented Apr 30, 2019

adxsdknet commented Apr 30, 2019 •

edited

Loading

dsgouda left a comment

huang91shu commented Apr 30, 2019

dsgouda commented May 16, 2019

sergey-shandar commented May 23, 2019

dsgouda commented May 23, 2019

dsgouda left a comment

huang91shu commented May 28, 2019

vchske commented May 29, 2019

Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801

Add OracleAzureDbPostgreSQLSync scenario and ServiceTask resource #5801

Conversation

huang91shu commented Apr 30, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Apr 30, 2019

adxsdknet commented Apr 30, 2019 • edited Loading

Automation for azure-sdk-for-net

dsgouda left a comment

Choose a reason for hiding this comment

huang91shu commented Apr 30, 2019

dsgouda commented May 16, 2019

sergey-shandar commented May 23, 2019

dsgouda commented May 23, 2019

dsgouda left a comment

Choose a reason for hiding this comment

huang91shu commented May 28, 2019

vchske commented May 29, 2019

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

AutorestCI commented Apr 30, 2019 •

edited

Loading

adxsdknet commented Apr 30, 2019 •

edited

Loading