Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

vchske · 2019-06-26T00:33:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Merging from Azure latest

Get latest from Azure

Merging latest from Azure

openapi-sdkautomation · 2019-06-26T00:33:50Z

SDK Automation [Logs] (Generated from 4f5182d)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/datamigration/azure-mgmt-datamigration [Logs] [Instructions]
- azure-mgmt-datamigration-2.2.0.zip
- azure_mgmt_datamigration-2.2.0-py2.py3-none-any.whl

Go: Azure/azure-sdk-for-go [Logs]

No packages generated.

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

No packages generated.

Java: Azure/azure-sdk-for-java [Logs] [Diff]

azuredatabasemigrationservice/resource-manager/v2017_11_15_preview [Logs] [Instructions]
azuredatabasemigrationservice/resource-manager/v2018_03_31_preview [Logs] [Instructions]
azuredatabasemigrationservice/resource-manager/v2018_07_15_preview [Logs]

AutorestCI · 2019-06-26T00:34:28Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-06-26T00:35:43Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5417

azuresdkci · 2019-06-26T00:36:30Z

Can one of the admins verify this patch?

hitenjava · 2019-06-26T00:36:56Z

...ft.DataMigration/preview/2018-07-15-preview/definitions/OracleAzureDbPostgreSqlSyncTask.json

+        "selectedSchemas"
+      ]
+    },
+    "GetUserTablesOracleTaskOutput": {


Missing change - Where are these being referred?

Are you referring to the missing parts in Tasks.json? If so, these have been added now.

AutorestCI · 2019-06-26T00:43:13Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5224

AutorestCI · 2019-06-26T00:44:53Z

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#3730

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

...ft.DataMigration/preview/2018-07-15-preview/definitions/OracleAzureDbPostgreSqlSyncTask.json

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json

vchske · 2019-06-26T22:55:32Z

@erich-wang I was told that instead of submitting a new commit for any changes that I should force the new changes onto a single commit. As I am not a git master, do you have guidance on how this is done?

nschonni · 2019-06-27T00:24:29Z

@vchske I think they "squash merge" when landing PRs, so you should be able to just push the additional commit. If you want to cleanup the commits down to 1, you can use a rebase and squash like http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html and then git push -f to force the new single commit as the branch

erich-wang · 2019-06-27T11:00:02Z

@vchske , please resolve the comments from @huang91shu and @hitenjava.

…tgreSQL databases and tables 2

vchske · 2019-07-01T21:36:33Z

@erich-wang Comments have been resolved and the change is approved so I think we are ready for a merge.

erich-wang · 2019-07-02T03:45:43Z

@vchske , I just noticed that you missed the ARM API Review Checklist, so just added WaitForARMFeedback. Of course we could skip this step if @huang91shu is from ARM review board.

vchske · 2019-07-02T18:44:15Z

@erich-wang We aren't making a breaking change with this. We aren't adding or removing an API endpoint. Based on this, I don't believe an ARM review is necessary. This is essentially the same as #5801 and that one also did not require an ARM review.

erich-wang · 2019-07-03T02:04:44Z

@vchske , you're adding properties which falls into below checklist:

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

erich-wang · 2019-07-08T02:27:13Z

@ravbhatnagar, could you help review this PR from ARM perspective?

…tgreSQL databases and tables (Azure#6456) * Update MongoDbTasks.json * Update readme.md * Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables 2

vchske added 5 commits October 25, 2018 16:32

Update MongoDbTasks.json

66f3328

Update readme.md

c2b76af

Merge pull request #1 from Azure/master

2bd2238

Merging from Azure latest

Merge pull request #2 from Azure/master

c3743b7

Get latest from Azure

Merge pull request #3 from Azure/master

39709cb

Merging latest from Azure

vchske requested a review from hitenjava as a code owner June 26, 2019 00:33

hitenjava requested a review from huang91shu June 26, 2019 00:34

azuresdkci assigned erich-wang Jun 26, 2019

azuresdkci requested a review from erich-wang June 26, 2019 00:35

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR datamigration/resource-manager] Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables Azure/azure-sdk-for-python#6096

Merged

hitenjava reviewed Jun 26, 2019

View reviewed changes

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR datamigration/resource-manager] Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables Azure/azure-sdk-for-go#5121

Merged

AutorestCI mentioned this pull request Jun 26, 2019

[AutoPR datamigration/resource-manager] Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables Azure/azure-sdk-for-java#4117

Closed

huang91shu suggested changes Jun 26, 2019

View reviewed changes

erich-wang suggested changes Jun 26, 2019

View reviewed changes

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json Outdated Show resolved Hide resolved

nschonni reviewed Jun 26, 2019

View reviewed changes

.../resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Common.json Outdated Show resolved Hide resolved

erich-wang approved these changes Jun 27, 2019

View reviewed changes

Adding objects necessary for mapping Oracle schemas and tables to Pos…

4f5182d

…tgreSQL databases and tables 2

huang91shu approved these changes Jul 1, 2019

View reviewed changes

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 2, 2019

ryansbenson approved these changes Jul 10, 2019

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 10, 2019

erich-wang merged commit b453699 into Azure:master Jul 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

vchske commented Jun 26, 2019

openapi-sdkautomation bot commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

azuresdkci commented Jun 26, 2019

hitenjava Jun 26, 2019

vchske Jun 28, 2019

AutorestCI commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

vchske commented Jun 26, 2019

nschonni commented Jun 27, 2019

erich-wang commented Jun 27, 2019

vchske commented Jul 1, 2019

erich-wang commented Jul 2, 2019

vchske commented Jul 2, 2019

erich-wang commented Jul 3, 2019

erich-wang commented Jul 8, 2019

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

Adding objects necessary for mapping Oracle schemas and tables to PostgreSQL databases and tables #6456

Conversation

vchske commented Jun 26, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Jun 26, 2019 • edited Loading

SDK Automation [Logs] (Generated from 4f5182d)

AutorestCI commented Jun 26, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jun 26, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Jun 26, 2019

hitenjava Jun 26, 2019

Choose a reason for hiding this comment

vchske Jun 28, 2019

Choose a reason for hiding this comment

AutorestCI commented Jun 26, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 26, 2019 • edited Loading

Automation for azure-sdk-for-java

vchske commented Jun 26, 2019

nschonni commented Jun 27, 2019

erich-wang commented Jun 27, 2019

vchske commented Jul 1, 2019

erich-wang commented Jul 2, 2019

vchske commented Jul 2, 2019

erich-wang commented Jul 3, 2019

erich-wang commented Jul 8, 2019

openapi-sdkautomation bot commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading

AutorestCI commented Jun 26, 2019 •

edited

Loading