Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Microsoft.Network NetworkVirtualAppliance resource #8010

Closed
wants to merge 3 commits into from
Closed

Add new Microsoft.Network NetworkVirtualAppliance resource #8010

wants to merge 3 commits into from

Conversation

naveenchekuri
Copy link
Contributor

@naveenchekuri naveenchekuri commented Dec 19, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@zikalino zikalino added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 27, 2019
anton-evseev
anton-evseev suggested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix validation errors

...on/network/resource-manager/Microsoft.Network/stable/2019-11-01/networkVirtualAppliance.json Outdated Show resolved Hide resolved
...on/network/resource-manager/Microsoft.Network/stable/2019-11-01/networkVirtualAppliance.json Outdated Show resolved Hide resolved
@ryansbenson ryansbenson added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2020
@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

anton-evseev
anton-evseev suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your examples you use "networkVirtualApplianceName", but it specs it's "networkVirtualAppliance"
Please use "networkVirtualApplianceName" to keep consistency with other specs

@anton-evseev
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@MikhailTryakhov
Copy link
Contributor

Hey @naveenchekuri, we are close to release our monthly branch. In case you won't solve all the failed jobs/get ARM approval - your PR would be closed around midnight today (PST time)

@sanjaiganesh sanjaiganesh removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 16, 2020
@sanjaiganesh sanjaiganesh added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 16, 2020
v-shhatt
v-shhatt reviewed Jan 16, 2020
View reviewed changes
Copy link
Contributor

@v-shhatt v-shhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix prettier checks, model and network validation errors

@anton-evseev
Copy link
Contributor

network-december-release has been already merged to meep tight deadlines. If your PR is urgent, please retarget to master

@MikhailTryakhov
Copy link
Contributor

Closing due to branch was already merged. Please use network-january-release branch

@naveenchekuri naveenchekuri mentioned this pull request Jan 30, 2020
Merged
5 tasks
@naveenchekuri naveenchekuri mentioned this pull request Jun 12, 2020
Closed
golddove added a commit that referenced this pull request Jul 28, 2022
@golddove
[Hub Generated] Review request for Microsoft.StorageMover to add vers…
d8e3ebc 
…ion preview/2022-07-01-preview (#8045)

* Microsoft.StorageMover add 200 response code to Delete operations (#8010)

* Microsoft.StorageMover - Make parent of required properties also required (#8034)

* Update examples
raych1 pushed a commit that referenced this pull request Jul 29, 2022
@golddove
[Hub Generated] Review request for Microsoft.StorageMover to add vers…
913f1e8 
…ion preview/2022-07-01-preview (#8045) (#19992)

* Microsoft.StorageMover add 200 response code to Delete operations (#8010)

* Microsoft.StorageMover - Make parent of required properties also required (#8034)

* Update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@ryansbenson ryansbenson ryansbenson left review comments

@v-shhatt v-shhatt v-shhatt left review comments

@anton-evseev anton-evseev anton-evseev requested changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

@zikalino zikalino Awaiting requested review from zikalino

Assignees

@zikalino zikalino

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@naveenchekuri @azuresdkci @anton-evseev @MikhailTryakhov @sanjaiganesh @ryansbenson @v-shhatt @zikalino