Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rp cop #8034

Merged
merged 7 commits into from
Jan 8, 2020
Merged

Fix rp cop #8034

merged 7 commits into from
Jan 8, 2020

Conversation

wenjlu-lgy
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 26, 2019 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 26, 2019 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 26, 2019 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 26, 2019 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 26, 2019 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@wenjlu-lgy
Copy link
Contributor Author

@bganapa Could you please check this?

@fengzhou-msft fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 27, 2019
@bganapa bganapa added Azure Stack and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 27, 2019
@bganapa
Copy link
Member

bganapa commented Dec 27, 2019

@fengzhou-msft The API surface is specific to Azure stack Admin endpoint .These are not exposed in Azure at all. These APIs does not go thru ARM API Review. I removed the WaitForArmFeedback tag.
Could you please help us show how we can fix the validation errors?

@fengzhou-msft
Copy link
Member

@bganapa Please check error details on ADO log and you should be able to see which line has what issue.

@bganapa
Copy link
Member

bganapa commented Dec 28, 2019

@wenjlu-lgy to look in to the errors

@bganapa
Copy link
Member

bganapa commented Jan 2, 2020

@wenjlu-lgy Could you please look in to this?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bganapa
Copy link
Member

bganapa commented Jan 8, 2020

@fengzhou-msft This should be good to merge now. Thanks!

@fengzhou-msft fengzhou-msft merged commit 4aad8ca into Azure:master Jan 8, 2020
golddove added a commit that referenced this pull request Jul 28, 2022
@golddove
[Hub Generated] Review request for Microsoft.StorageMover to add vers…
d8e3ebc 
…ion preview/2022-07-01-preview (#8045)

* Microsoft.StorageMover add 200 response code to Delete operations (#8010)

* Microsoft.StorageMover - Make parent of required properties also required (#8034)

* Update examples
raych1 pushed a commit that referenced this pull request Jul 29, 2022
@golddove
[Hub Generated] Review request for Microsoft.StorageMover to add vers…
913f1e8 
…ion preview/2022-07-01-preview (#8045) (#19992)

* Microsoft.StorageMover add 200 response code to Delete operations (#8010)

* Microsoft.StorageMover - Make parent of required properties also required (#8034)

* Update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
Azure Stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenjlu-lgy @azuresdkci @bganapa @fengzhou-msft