[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 #8240

AndyTao0402 · 2020-01-28T00:57:58Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…e API

azure-pipelines · 2020-01-28T00:58:15Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-28T00:59:41Z

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe02362 with merge commit ce1cf707d02ebd4929ba77b3b8812232e083611a. SDK Automation 13.0.17.20191226.1
️✔️azurestack/mgmt/2017-06-01 [Logs] [Preview SDK Changes]
- azurestack.mgmt.2017-06-01.zip

openapi-sdkautomation · 2020-01-28T00:59:45Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe02362 with merge commit ce1cf707d02ebd4929ba77b3b8812232e083611a. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-azurestack [Logs] [Preview SDK Changes]

azure-arm-azurestack-2.0.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/azureStackManagementClient.js → ./dist/arm-azurestack.js...
[npmPack] created ./dist/arm-azurestack.js in 310ms

openapi-sdkautomation · 2020-01-28T00:59:46Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from fe02362 with merge commit ce1cf707d02ebd4929ba77b3b8812232e083611a. SDK Automation 13.0.17.20191226.1

⚠️sdk/azurestack/mgmt-v2017_06_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[469,155] cannot find symbol
[mvn]   symbol:   variable deviceConfiguration
[mvn]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[562,167] cannot find symbol
[mvn]   symbol:   variable deviceConfiguration
[mvn]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[655,166] cannot find symbol
[mvn]   symbol:   variable marketplaceProductLogUpdate
[mvn]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/RegistrationImpl.java:[27,67] incompatible types: java.lang.String cannot be converted to com.microsoft.azure.management.azurestack.v2017_06_01.Location
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-azurestack: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[469,155] cannot find symbol
[mvn] [ERROR]   symbol:   variable deviceConfiguration
[mvn] [ERROR]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[562,167] cannot find symbol
[mvn] [ERROR]   symbol:   variable deviceConfiguration
[mvn] [ERROR]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/ProductsInner.java:[655,166] cannot find symbol
[mvn] [ERROR]   symbol:   variable marketplaceProductLogUpdate
[mvn] [ERROR]   location: class com.microsoft.azure.management.azurestack.v2017_06_01.implementation.ProductsInner
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/azurestack/mgmt-v2017_06_01/src/main/java/com/microsoft/azure/management/azurestack/v2017_06_01/implementation/RegistrationImpl.java:[27,67] incompatible types: java.lang.String cannot be converted to com.microsoft.azure.management.azurestack.v2017_06_01.Location
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-01-28T00:59:50Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from fe02362 with merge commit ce1cf707d02ebd4929ba77b3b8812232e083611a. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-azurestack [Logs] [Preview SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2020-01-28T00:59:51Z

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-01-28T01:02:11Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-28T01:02:13Z

Azure Pipelines successfully started running 1 pipeline(s).

allenjzhang · 2020-01-30T18:30:21Z

Please review failures and ensure checks are passing. Without green check results, PR cannot be merged. Thx.

...on/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/CloudManifestFile.json

azure-pipelines · 2020-02-03T20:12:04Z

Azure Pipelines successfully started running 1 pipeline(s).

allenjzhang · 2020-02-03T22:19:34Z

Please review check pipeline failures and make corrections. Thanks.

azure-pipelines · 2020-02-03T22:21:34Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-04T23:47:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T20:24:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-05T20:48:40Z

Azure Pipelines failed to run 1 pipeline(s).

bganapa · 2020-02-05T21:54:22Z

@allenjzhang The checks are passing now. Could you please add the ARM folks as reviewers for sign off?

allenjzhang · 2020-02-09T05:26:08Z

/azp run automation - sdk

azure-pipelines · 2020-02-09T05:26:16Z

Azure Pipelines successfully started running 1 pipeline(s).

majastrz · 2020-02-14T01:42:52Z

...ification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/AzureStack.json

@@ -44,6 +44,53 @@
          "nextLinkName": "nextLink"
        }
      }
+    },
+    "/providers/Microsoft.AzureStack/cloudmanifestfile": {


cloudmanifestfile [](start = 37, length = 17)

As per the RPC, resource type names should be plural. If it's a singleton, the correct pattern would be to implement the following routes:

/providers/Microsoft.AzureStack/cloudmanifestfiles

/providers/Microsoft.AzureStack/cloudmanifestfiles/default

default can be substituted with master, current, or latest depending on the requirements.

You need the list route also (/providers/Microsoft.AzureStack/cloudmanifestfiles). Yes, I know it's weird to have it just for 1 result, but that's the pattern.

In reply to: 379690800 [](ancestors = 379690800)

Do I have to implement the API for list? We don't have a use case for that.

Yeah :(. GET verb in ARM RPC is reserved for resources, which for a read-only resource like this would require LIST and GET at minimum. The other alternative would be to make it a POST action.

For some reason, I couldn't get proxy action work on tenant level. And this should not be a POST. I'll probably implement the list same as GET default.

...urestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Operation/Get.json

majastrz

Please take a look at the comments I added.

azure-pipelines · 2020-02-14T23:38:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-14T23:48:37Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T18:24:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T18:37:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T19:29:28Z

Azure Pipelines successfully started running 1 pipeline(s).

ravbhatnagar

@AndyTao0402 - just one more minor comment.

ravbhatnagar · 2020-02-18T19:39:44Z

...ification/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/AzureStack.json

@@ -44,6 +44,86 @@
          "nextLinkName": "nextLink"
        }
      }
+    },
+    "/providers/Microsoft.AzureStack/cloudmanifestfiles": {


can you camel case the resource type name? cloudManifestFiles?

is this not caught by linter? surprised

azure-pipelines · 2020-02-18T20:00:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T21:42:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-18T22:03:06Z

Azure Pipelines successfully started running 1 pipeline(s).

AndyTao0402 · 2020-02-21T19:01:00Z

ARM reviewers, could you please approve?

ravbhatnagar · 2020-02-24T18:56:49Z

signing off!

…n stable/2017-06-01 (Azure#8240) * Update AzureStack API descriptions to include new GetCloudManifestFile API * Add CloudManifestFile example * Fix for spell check * Remove CloudName * Move new operation to AzureStack.json * Fix model error * Add one more optional query parameter * Address PR comments * Fix spell check * Add list operation * Fix style * Actually fix stykle * Use camel case name * Modify operation description * Fix Operation List example

Update AzureStack API descriptions to include new GetCloudManifestFil…

b977722

…e API

openapi-assignment-bot bot assigned allenjzhang Jan 28, 2020

openapi-sdkautomation bot mentioned this pull request Jan 28, 2020

[AutoPR sdk/azurestack/mgmt-v2017_06_01] [Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 AzureSDKAutomation/azure-sdk-for-java#851

Open

allenjzhang reviewed Jan 30, 2020

View reviewed changes

...on/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/CloudManifestFile.json Outdated Show resolved Hide resolved

allenjzhang reviewed Jan 31, 2020

View reviewed changes

...on/azurestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/CloudManifestFile.json Outdated Show resolved Hide resolved

Add CloudManifestFile example

173f80b

allenjzhang approved these changes Feb 3, 2020

View reviewed changes

allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 3, 2020

Fix for spell check

b5a54e6

Remove CloudName

338096e

Move new operation to AzureStack.json

93ff05e

Fix model error

cc8fc0d

majastrz reviewed Feb 14, 2020

View reviewed changes

...urestack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Operation/Get.json Outdated Show resolved Hide resolved

majastrz added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 14, 2020

majastrz reviewed Feb 14, 2020

View reviewed changes

Address PR comments

9be1c31

Fix spell check

a1af0c7

Add list operation

4994215

Fix style

0726bf6

Actually fix stykle

c0bee08

ravbhatnagar reviewed Feb 18, 2020

View reviewed changes

Use camel case name

9d58298

Modify operation description

4085491

Fix Operation List example

fe02362

bganapa approved these changes Feb 21, 2020

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Feb 24, 2020

allenjzhang merged commit 9643f83 into Azure:master Feb 24, 2020

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 #8240

[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 #8240

Conversation

AndyTao0402 commented Jan 28, 2020 • edited Loading

Contribution checklist:

azure-pipelines bot commented Jan 28, 2020

openapi-sdkautomation bot commented Jan 28, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Jan 28, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Jan 28, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Jan 28, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Jan 28, 2020 • edited Loading

azure-sdk-for-net

azure-pipelines bot commented Jan 28, 2020

azure-pipelines bot commented Jan 28, 2020

allenjzhang commented Jan 30, 2020

azure-pipelines bot commented Feb 3, 2020

allenjzhang commented Feb 3, 2020

azure-pipelines bot commented Feb 3, 2020

azure-pipelines bot commented Feb 4, 2020

azure-pipelines bot commented Feb 5, 2020

azure-pipelines bot commented Feb 5, 2020

bganapa commented Feb 5, 2020

allenjzhang commented Feb 9, 2020

azure-pipelines bot commented Feb 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majastrz Feb 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 14, 2020

azure-pipelines bot commented Feb 14, 2020

azure-pipelines bot commented Feb 18, 2020

azure-pipelines bot commented Feb 18, 2020

azure-pipelines bot commented Feb 18, 2020

ravbhatnagar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 18, 2020

azure-pipelines bot commented Feb 18, 2020

azure-pipelines bot commented Feb 18, 2020

AndyTao0402 commented Feb 21, 2020

ravbhatnagar commented Feb 24, 2020

AndyTao0402 commented Jan 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 28, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 28, 2020 •

edited

Loading

majastrz Feb 14, 2020 •

edited

Loading