-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.AzureStack to add version stable/2017-06-01 #8240
Merged
allenjzhang
merged 15 commits into
Azure:master
from
AndyTao0402:dev-azurestack-Microsoft.AzureStack-2017-06-01
Feb 24, 2020
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b977722
Update AzureStack API descriptions to include new GetCloudManifestFil…
AndyTao0402 173f80b
Add CloudManifestFile example
AndyTao0402 b5a54e6
Fix for spell check
AndyTao0402 338096e
Remove CloudName
AndyTao0402 93ff05e
Move new operation to AzureStack.json
AndyTao0402 cc8fc0d
Fix model error
AndyTao0402 42fd4b2
Add one more optional query parameter
AndyTao0402 9be1c31
Address PR comments
AndyTao0402 a1af0c7
Fix spell check
AndyTao0402 4994215
Add list operation
AndyTao0402 0726bf6
Fix style
AndyTao0402 c0bee08
Actually fix stykle
AndyTao0402 9d58298
Use camel case name
AndyTao0402 4085491
Modify operation description
AndyTao0402 fe02362
Fix Operation List example
AndyTao0402 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1696,3 +1696,5 @@ getactivesessions | |
disconnectactivesessions | ||
bsls | ||
sessionids | ||
Dsms | ||
cloudmanifestfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...stack/resource-manager/Microsoft.AzureStack/stable/2017-06-01/examples/Operation/Get.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"parameters": { | ||
"api-version": "2017-06-01" | ||
}, | ||
"responses": { | ||
"200": { | ||
"body": { | ||
"value": { | ||
"deploymentData": { | ||
"externalDsmsCertificates": "", | ||
"customCloudVerificationKey": "", | ||
"customEnvironmentEndpoints": { | ||
"customCloudArmEndpoint": "https://management.azure.microsoft.scloud/", | ||
"externalDsmsEndpoint": "https://global-dsms.dsms.core.microsoft.scloud/dsms/issuercertificates" | ||
} | ||
}, | ||
"signature": "" | ||
} | ||
majastrz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the RPC, resource type names should be plural. If it's a singleton, the correct pattern would be to implement the following routes:
/providers/Microsoft.AzureStack/cloudmanifestfiles
/providers/Microsoft.AzureStack/cloudmanifestfiles/default
default
can be substituted withmaster
,current
, orlatest
depending on the requirements.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need the list route also (
/providers/Microsoft.AzureStack/cloudmanifestfiles
). Yes, I know it's weird to have it just for 1 result, but that's the pattern.In reply to: 379690800 [](ancestors = 379690800)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I have to implement the API for list? We don't have a use case for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah :(. GET verb in ARM RPC is reserved for resources, which for a read-only resource like this would require LIST and GET at minimum. The other alternative would be to make it a POST action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, I couldn't get proxy action work on tenant level. And this should not be a POST. I'll probably implement the list same as GET default.