New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Stack] Add TargetScaleUnit and TargetVolumeLabel parameters for disk migration job #8409

Merged

bganapa merged 1 commit into Azure:stackadmin from zyxyoshine:para

Feb 17, 2020

Contributor

zyxyoshine commented Feb 16, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          Add TargetScaleUnitParameter and TargetVolumeLabelParameter

1c5f47f

openapi-assignment-bot bot assigned ArcturusZhang

azure-pipelines bot commented Feb 16, 2020

Azure Pipelines successfully started running 1 pipeline(s).

zyxyoshine requested a review from bganapa

February 16, 2020 10:17

Contributor Author

zyxyoshine commented Feb 16, 2020

This is for Azure Stack API, @bganapa please help review.

openapi-sdkautomation bot commented Feb 16, 2020 •

edited

Loading

azure-sdk-for-go

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Feb 16, 2020 •

edited

Loading

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Feb 16, 2020 •

edited

Loading

azure-sdk-for-js

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Feb 16, 2020 •

edited

Loading

azure-sdk-for-net

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation bot commented Feb 16, 2020 •

edited

Loading

azure-sdk-for-python

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

bganapa reviewed

View reviewed changes

...ce-manager/compute/Microsoft.Compute.Admin/preview/2018-07-30-preview/DiskMigrationJobs.json Show resolved Hide resolved

bganapa approved these changes

View reviewed changes

bganapa merged commit ac2ee55 into Azure:stackadmin

viananth added a commit to viananth/azure-rest-api-specs that referenced this pull request


          Cumulative commit message:

2fabd58

commit 4ec980f (azure/stackadmin)
Author: Yuxing Zhou <[email protected]>
Date:   Wed Mar 18 15:14:57 2020 +0800

    [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733)

    * add scaleUnit and volumeLabel to Disks_List

    * fix ref location

    * update parameter description

commit c70efa6
Author: bganapa <[email protected]>
Date:   Tue Feb 25 19:33:53 2020 -0800

    Updating ReadMe to include (this-folder)

commit ac2ee55
Author: Yuxing Zhou <[email protected]>
Date:   Mon Feb 17 08:52:02 2020 +0800

    Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409)

commit 79944a3
Author: hannah-murphy-0 <[email protected]>
Date:   Thu Feb 13 17:25:47 2020 -0800

    Adding publisher field to VMExtension model (Azure#8398)
                                                                                                                        commit 8ef2c06                                                                         Merge: 4691c2a b53a498                                                                                              Author: bganapa <[email protected]>                            Date:   Tue Feb 4 22:11:56 2020 -0800                                        git merge upstream/master
    commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)

akning-ms pushed a commit that referenced this pull request


          [Azure Stack] Updates to Azs.Compute.Admin spec for autorest config (#…

3030d86

…9032)

* Cumulative commit message:
commit 4ec980f (azure/stackadmin)
Author: Yuxing Zhou <[email protected]>
Date:   Wed Mar 18 15:14:57 2020 +0800

    [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (#8733)

    * add scaleUnit and volumeLabel to Disks_List

    * fix ref location

    * update parameter description

commit c70efa6
Author: bganapa <[email protected]>
Date:   Tue Feb 25 19:33:53 2020 -0800

    Updating ReadMe to include (this-folder)

commit ac2ee55
Author: Yuxing Zhou <[email protected]>
Date:   Mon Feb 17 08:52:02 2020 +0800

    Add TargetScaleUnitParameter and TargetVolumeLabelParameter (#8409)

commit 79944a3
Author: hannah-murphy-0 <[email protected]>
Date:   Thu Feb 13 17:25:47 2020 -0800

    Adding publisher field to VMExtension model (#8398)
                                                                                                                        commit 8ef2c06                                                                         Merge: 4691c2a b53a498                                                                                              Author: bganapa <[email protected]>                            Date:   Tue Feb 4 22:11:56 2020 -0800                                        git merge upstream/master
    commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (#7766)

* Add autorest config to readme.md

* Fix path reference

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request


          [Azure Stack] Updates to Azs.Compute.Admin spec for autorest config (A…

1bae52e

…zure#9032)

* Cumulative commit message:
commit 4ec980f (azure/stackadmin)
Author: Yuxing Zhou <[email protected]>
Date:   Wed Mar 18 15:14:57 2020 +0800

    [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733)

    * add scaleUnit and volumeLabel to Disks_List

    * fix ref location

    * update parameter description

commit c70efa6
Author: bganapa <[email protected]>
Date:   Tue Feb 25 19:33:53 2020 -0800

    Updating ReadMe to include (this-folder)

commit ac2ee55
Author: Yuxing Zhou <[email protected]>
Date:   Mon Feb 17 08:52:02 2020 +0800

    Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409)

commit 79944a3
Author: hannah-murphy-0 <[email protected]>
Date:   Thu Feb 13 17:25:47 2020 -0800

    Adding publisher field to VMExtension model (Azure#8398)
                                                                                                                        commit 8ef2c06                                                                         Merge: 4691c2a b53a498                                                                                              Author: bganapa <[email protected]>                            Date:   Tue Feb 4 22:11:56 2020 -0800                                        git merge upstream/master
    commit 9e551f0
Author: bganapa <[email protected]>
Date:   Tue Nov 12 11:44:22 2019 -0800

    Reset to Stackadmin2 (Azure#7766)

* Add autorest config to readme.md

* Fix path reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet