-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Stack] Updates to Azs.Compute.Admin spec for autorest config #9032
Conversation
commit 4ec980f (azure/stackadmin) Author: Yuxing Zhou <[email protected]> Date: Wed Mar 18 15:14:57 2020 +0800 [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733) * add scaleUnit and volumeLabel to Disks_List * fix ref location * update parameter description commit c70efa6 Author: bganapa <[email protected]> Date: Tue Feb 25 19:33:53 2020 -0800 Updating ReadMe to include (this-folder) commit ac2ee55 Author: Yuxing Zhou <[email protected]> Date: Mon Feb 17 08:52:02 2020 +0800 Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409) commit 79944a3 Author: hannah-murphy-0 <[email protected]> Date: Thu Feb 13 17:25:47 2020 -0800 Adding publisher field to VMExtension model (Azure#8398) commit 8ef2c06 Merge: 4691c2a b53a498 Author: bganapa <[email protected]> Date: Tue Feb 4 22:11:56 2020 -0800 git merge upstream/master commit 9e551f0 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766)
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@@ -56,32 +56,16 @@ csharp: | |||
clear-output-folder: true | |||
``` | |||
|
|||
## Multi-API/Profile support for AutoRest v3 generators | |||
# AutoRest v3 generators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont need to change this part i think
@@ -44,6 +44,12 @@ | |||
{ | |||
"$ref": "Disks.json#/parameters/SourceSharePathParameter" | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyxyoshine Havent you made this change already to master? you made this only in stackadmin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
@zyxyoshine could you please approve this PR if it looks good to you? Thanks! |
@fengzhou-msft could you pls merge this PR if it looks good to you? Thanks! |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@KrisBash Do you need anything to be fixed here? Could you pls merge this |
@fengzhou-msft is there any changes you are expecting? Could you please merge if it looks good? Kris had already signed off. |
@viananth sorry for the delay, I do not have permission to force merge the PR. @akning-ms can you help merge this PR? |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
…zure#9032) * Cumulative commit message: commit 4ec980f (azure/stackadmin) Author: Yuxing Zhou <[email protected]> Date: Wed Mar 18 15:14:57 2020 +0800 [Azure Stack] Add scaleUnit and volumeLabel parameter to Disks_List (Azure#8733) * add scaleUnit and volumeLabel to Disks_List * fix ref location * update parameter description commit c70efa6 Author: bganapa <[email protected]> Date: Tue Feb 25 19:33:53 2020 -0800 Updating ReadMe to include (this-folder) commit ac2ee55 Author: Yuxing Zhou <[email protected]> Date: Mon Feb 17 08:52:02 2020 +0800 Add TargetScaleUnitParameter and TargetVolumeLabelParameter (Azure#8409) commit 79944a3 Author: hannah-murphy-0 <[email protected]> Date: Thu Feb 13 17:25:47 2020 -0800 Adding publisher field to VMExtension model (Azure#8398) commit 8ef2c06 Merge: 4691c2a b53a498 Author: bganapa <[email protected]> Date: Tue Feb 4 22:11:56 2020 -0800 git merge upstream/master commit 9e551f0 Author: bganapa <[email protected]> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766) * Add autorest config to readme.md * Fix path reference
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.