Skip to content

Commit

Permalink
Update CODEOWNERS paths: fix invalid paths
Browse files Browse the repository at this point in the history
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240

Related PRs:
- Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584
- Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534
  • Loading branch information
Konrad Jamrozik authored Feb 10, 2023
1 parent dd6cb8b commit f8fbaaf
Showing 1 changed file with 10 additions and 15 deletions.
25 changes: 10 additions & 15 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
# Instructions for CODEOWNERS file format and automatic build failure notifications:
# https://github.com/Azure/azure-sdk/blob/master/docs/policies/opensource.md#codeowners

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @jhendrixMSFT @rickwinter @ronniegeraghty

#############
# SDK (track2)
#############

# Catch all for non-code project files and unowned files | folders
* @rickwinter @jhendrixMSFT
/** @rickwinter @jhendrixMSFT
/sdk/ @rickwinter @chlowell @richardpark-msft

# Samples
Expand Down Expand Up @@ -41,13 +34,10 @@
/sdk/keyvault/ @chlowell @jhendrixMSFT

# PRLabel: %Service Bus
/sdk/messaging/azservicebus @richardpark-msft @jhendrixMSFT
/sdk/messaging/azservicebus/ @richardpark-msft @jhendrixMSFT

# PRLabel: %Event Hubs
/sdk/messaging/azeventhubs @richardpark-msft @jhendrixMSFT

# PRLabel: %Service Bus
/sdk/messaging/internal @richardpark-msft @jhendrixMSFT
/sdk/messaging/azeventhubs/ @richardpark-msft @jhendrixMSFT

# PRLabel: %Monitor
/sdk/monitor/ @gracewilcox @chlowell @jhendrixMSFT
Expand All @@ -58,12 +48,17 @@
# PRLabel: %Storage
/sdk/storage/ @siminsavani-msft @souravgupta-msft @tasherif-msft @jhendrixMSFT @gapra-msft

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @jhendrixMSFT @rickwinter @ronniegeraghty

###########
# Eng Sys
###########
/eng/ @benbp @weshaggard
/**/ci.yml @benbp
/**/tests.yml @benbp

# PRLabel: %EngSys
/sdk/template/ @benbp @weshaggard

0 comments on commit f8fbaaf

Please sign in to comment.