Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable regex-based wildcard-supporting CODEOWNERS matcher for azure-sdk-for-net repo #5241

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Enable regex-based wildcard-supporting CODEOWNERS matcher for azure-sdk-for-net repo #5241

merged 1 commit into from
Jan 27, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Jan 26, 2023 •
edited
Loading

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jan 26, 2023
@konrad-jamrozik konrad-jamrozik requested a review from a team as a code owner January 26, 2023 21:56
@konrad-jamrozik konrad-jamrozik self-assigned this Jan 26, 2023
@konrad-jamrozik konrad-jamrozik changed the title Enable regex-based CODEOWNERS matcher for azure-sdk-for-net Enable regex-based wildcard-supporting CODEOWNERS matcher for azure-sdk-for-net Jan 26, 2023
@konrad-jamrozik konrad-jamrozik changed the title Enable regex-based wildcard-supporting CODEOWNERS matcher for azure-sdk-for-net Enable regex-based wildcard-supporting CODEOWNERS matcher for azure-sdk-for-net repo Jan 26, 2023
This was referenced Jan 27, 2023
Merged
Merged
@konrad-jamrozik konrad-jamrozik merged commit e33ae8f into main Jan 27, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/wildcard_for_net branch January 27, 2023 23:13
@konrad-jamrozik konrad-jamrozik mentioned this pull request Jan 29, 2023
Merged
@konrad-jamrozik
Copy link
Contributor Author

konrad-jamrozik commented Jan 30, 2023 •
edited
Loading

I have updated the package (PR #5240) to pick up changes in this PR and I ran the pipeline which applied contact changes. You can find the changes in this pipeline run.

Search for Add Contact and Delete Contact.

For example we can see that owners of /sdk/keyvault/, for pipeline net - keyvault - tests are correctly reflected in the ADO team; you can find the team by looking at the build logs and searching for Evaluate Pipeline: Name = net - keyvault - tests, Path = \net, Id = 234 => Team Name = 234 Code owners sync notifications and Add contact, then going to
https://dev.azure.com/azure-sdk/internal/_settings/teams?subjectDescriptor=<teamDescriptorFromTheBuildLog>

Another example is pipeline net - dnsresolver - mgmt. Previously it matched against path /sdk/dns/ because the prefix-matcher was trimming /, but now it matches against /sdk/.

Yet another example is net - Azure.Monitor.OpenTelemetry.Exporter - tests that changed from /sdk/monitor/ to /sdk/monitor/Azure.Monitor.OpenTelemetry.*/

This was referenced Jan 30, 2023
Merged
Merged
Merged
Merged
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-go that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths
f8fbaaf 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240

Related PRs:
- Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584
- Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
konrad-jamrozik added a commit to Azure/azure-sdk-for-c that referenced this pull request Feb 10, 2023
@konrad-jamrozik
Update CODEOWNERS paths: fix invalid paths
7aac8c3 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-cpp that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths
9b265f3 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-ios that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths
daadb28 
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-android that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths
498725c 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
konrad-jamrozik pushed a commit to Azure/azure-dev that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths
8e548dd 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 10, 2023
Merged
ellismg pushed a commit to Azure/azure-dev that referenced this pull request Feb 10, 2023
Update CODEOWNERS paths: fix invalid paths (#1535)
d95956e 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
konrad-jamrozik added a commit to Azure/azure-sdk-for-c that referenced this pull request Feb 13, 2023
@konrad-jamrozik
Update CODEOWNERS paths: fix invalid paths (#2498)
ad29f02 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-ios that referenced this pull request Feb 13, 2023
Update CODEOWNERS paths: fix invalid paths (#1470)
8127825 
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-android that referenced this pull request Feb 13, 2023
Update CODEOWNERS paths: fix invalid paths (#1299)
f0bfb75 
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
konrad-jamrozik pushed a commit to Azure/azure-sdk-for-go that referenced this pull request Feb 13, 2023
@benbp
Update CODEOWNERS paths: fix invalid paths (#19994)
4f7ac15 
* Update `CODEOWNERS` paths: fix invalid paths

As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240

Related PRs:
- Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584
- Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534

* Update .github/CODEOWNERS

Co-authored-by: Ben Broderick Phillips <[email protected]>

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 14, 2023
Merged
ghost pushed a commit that referenced this pull request Feb 14, 2023
Use CodeownersFile.UseRegexMatcherDefault everywhere where applicab…
46834a0 
…le + remove obsolete tests (#5437)

This is a follow-up PR to:
- #5241

That PR was supposed to enable the regex-based matcher everywhere, but didn't. This PR fixes that.

This PR also:
- removes the obsolete `ProgramSimplePathTests` test class; it is superseded by `ProgramGlobPathTests`, which is renamed in:
    - #5431
- removes obsolete tests from `get-codeowners.ps1`

This PR is a prerequisite for following PRs:
- #5103
- #5431
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@benbp benbp Awaiting requested review from benbp

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konrad-jamrozik @weshaggard