Azure · RickWinter · Feb 8, 2023 · Feb 8, 2023 · Feb 8, 2023 · Feb 8, 2023
@@ -1,19 +1,12 @@
 # Instructions for CODEOWNERS file format and automatic build failure notifications:
 # https://github.com/Azure/azure-sdk/blob/master/docs/policies/opensource.md#codeowners
 
-################
-# Automation
-################
-
-# Git Hub integration and bot rules
-/.github/                    @jsquire @jhendrixMSFT @rickwinter @ronniegeraghty
-
 #############
 # SDK (track2)
 ############# 
 
 # Catch all for non-code project files and unowned files | folders
-*                             @rickwinter @jhendrixMSFT
+/**                           @rickwinter @jhendrixMSFT
 /sdk/                         @rickwinter @chlowell @richardpark-msft
 
 # Samples
@@ -40,14 +33,14 @@
 # PRLabel: %KeyVault
 /sdk/keyvault/                @chlowell @jhendrixMSFT
 
+# PRLabel: %KeyVault
+/sdk/security/keyvault/       @chlowell @jhendrixMSFT @gracewilcox
+
 # PRLabel: %Service Bus
-/sdk/messaging/azservicebus   @richardpark-msft @jhendrixMSFT
+/sdk/messaging/azservicebus/  @richardpark-msft @jhendrixMSFT
 
 # PRLabel: %Event Hubs
-/sdk/messaging/azeventhubs    @richardpark-msft @jhendrixMSFT
-
-# PRLabel: %Service Bus
-/sdk/messaging/internal       @richardpark-msft @jhendrixMSFT
+/sdk/messaging/azeventhubs/   @richardpark-msft @jhendrixMSFT
 
 # PRLabel: %Monitor
 /sdk/monitor/                 @gracewilcox @chlowell @jhendrixMSFT
@@ -56,14 +49,19 @@
 /sdk/resourcemanager/         @ArcturusZhang @lirenhe @tadelesh
 
 # PRLabel: %Storage
-/sdk/storage/                 @siminsavani-msft @souravgupta-msft @tasherif-msft @jhendrixMSFT @gapra-msft
+/sdk/storage/                 @siminsavani-msft @souravgupta-msft @tasherif-msft @jhendrixMSFT @gapra-msft @vibhansa-msft
+
+################
+# Automation
+################
+
+# Git Hub integration and bot rules
+/.github/                    @benbp @jsquire @jhendrixMSFT @rickwinter @ronniegeraghty
 
 ###########
 # Eng Sys
 ###########
 /eng/                         @benbp @weshaggard
-/**/ci.yml                    @benbp
-/**/tests.yml                 @benbp
 
 # PRLabel: %EngSys
 /sdk/template/                @benbp @weshaggard
@@ -1776,8 +1776,8 @@
               "Cosmos"
             ],
             "mentionees": [
-              "pjohari-ms",
-              "MehaKaushik"
+              "markjbrown",
+              "carjackson-msft"
             ]
           },
           {

@@ -86,3 +86,23 @@ There currently is not a repository wide way to build or regenerate code.
 #### Testing
 
 To test, run 'go test' from the respective directory.
+
+## Samples
+
+### Third-party dependencies
+
+Third party libraries should only be included in samples when necessary to demonstrate usage of an Azure SDK package; they should not be suggested or endorsed as alternatives to the Azure SDK.
+
+When code samples take dependencies, readers should be able to use the material without significant license burden or research on terms. This goal requires restricting dependencies to certain types of open source or commercial licenses.
+
+Samples may take the following categories of dependencies:
+
+- **Open-source** : Open source offerings that use an [Open Source Initiative (OSI) approved license](https://opensource.org/licenses). Any component whose license isn't OSI-approved is considered a commercial offering. Prefer OSS projects that are members of any of the [OSS foundations that Microsoft is part of](https://opensource.microsoft.com/ecosystem/). Prefer permissive licenses for libraries, like [MIT](https://opensource.org/licenses/MIT) and [Apache 2](https://opensource.org/licenses/Apache-2.0). Copy-left licenses like [GPL](https://opensource.org/licenses/gpl-license) are acceptable for tools, and OSs. [Kubernetes](https://github.com/kubernetes/kubernetes), [Linux](https://github.com/torvalds/linux), and [Newtonsoft.Json](https://github.com/JamesNK/Newtonsoft.Json) are examples of this license type. Links to open source components should be to where the source is hosted, including any applicable license, such as a GitHub repository (or similar).
+
+- **Commercial**: Commercial offerings that enable readers to learn from our content without unnecessary extra costs. Typically, the offering has some form of a community edition, or a free trial sufficient for its use in content. A commercial license may be a form of dual-license, or tiered license. Links to commercial components should be to the commercial site for the software, even if the source software is hosted publicly on GitHub (or similar).
+
+- **Dual licensed**: Commercial offerings that enable readers to choose either license based on their needs. For example, if the offering has an OSS and commercial license, readers can  choose between them. [MySql](https://github.com/mysql/mysql-server) is an example of this license type.
+
+- **Tiered licensed**: Offerings that enable readers to use the license tier that corresponds to their characteristics. For example, tiers may be available for students, hobbyists, or companies with defined revenue  thresholds. For offerings with tiered licenses, strive to limit our use in tutorials to the features available in the lowest tier. This policy enables the widest audience for the article. [Docker](https://www.docker.com/), [IdentityServer](https://duendesoftware.com/products/identityserver), [ImageSharp](https://sixlabors.com/products/imagesharp/), and [Visual Studio](https://visualstudio.com) are examples of this license type.
+
+In general, we prefer taking dependencies on licensed components in the order of the listed categories. In cases where the category may not be well known, we'll document the category so that readers understand the choice that they're making by using that dependency.
@@ -135,9 +135,7 @@ Testing is built into the Go toolchain as well with the `testing` library. The t
 | playback | `$ENV:AZURE_RECORD_MODE="playback"` | Running tests against recording HTTP interactiosn |
 | live | `$ENV:AZURE_RECORD_MODE="live"` | Bypassing test proxy, running against live service, and not recording HTTP interactions (used by live pipelines) |
 
-To get started first install [`docker`][get_docker]. Then to start the proxy, from the root of the repository, run the command `./eng/common/testproxy/docker-start-proxy.ps1 start`. This command will take care of pulling the pinned docker image and running it in the background.
-
-It is not required to run the test-proxy from within the docker container, but this is how the proxy is run in the Azure DevOps pipelines. If you would like to run the test-proxy in a different manner the [documentation][test_proxy_docs] has more information.
+To get started first [install test-proxy][test_proxy_install] via the standalone executable. Then to start the proxy, from the root of the repository, run the command `test-proxy start`.
 
 ### Test Mode Options
 
@@ -367,6 +365,7 @@ This creates the pipelines that will verify future PRs. The `azure-sdk-for-go` i
 [go_download]: https://golang.org/dl/
 [require_package]: https://pkg.go.dev/github.com/stretchr/testify/require
 [test_proxy_docs]: https://github.com/Azure/azure-sdk-tools/tree/main/tools/test-proxy
+[test_proxy_install]: https://github.com/Azure/azure-sdk-tools/blob/main/tools/test-proxy/Azure.Sdk.Tools.TestProxy/README.md#via-standalone-executable
 [workspace_setup]: https://www.digitalocean.com/community/tutorials/how-to-install-go-and-set-up-a-local-programming-environment-on-windows-10
 [directory_structure]: https://azure.github.io/azure-sdk/golang_introduction.html
 [module_design]: https://azure.github.io/azure-sdk/golang_introduction.html#azure-sdk-module-design

@@ -2,21 +2,27 @@ parameters:
 - name: JobName
   type: string
   default: 'Perf'
+- name: TimeoutInMinutes
+  type: number
+  default: '360'
 - name: LinuxPool
   type: string
-  default: 'azsdk-pool-mms-ubuntu-2004-perf'
+  default: 'azsdk-pool-mms-ubuntu-2204-perf'
 - name: LinuxVmImage
   type: string
-  default: 'MMSUbuntu20.04'
+  default: 'ubuntu-22.04'
 - name: WindowsPool
   type: string
-  default: 'azsdk-pool-mms-win-2019-perf'
+  default: 'azsdk-pool-mms-win-2022-perf'
 - name: WindowsVmImage
   type: string
-  default: 'MMS2019'
+  default: 'windows-2022'
 - name: Language
   type: string
   default: ''
+- name: LanguageVersion
+  type: string
+  default: ''
 - name: LanguageRepoName
   type: string
   default: $(Build.Repository.Name)
@@ -38,9 +44,6 @@ parameters:
 - name: ServiceDirectory
   type: string
   default: ''
-- name: Services
-  type: string
-  default: ''
 - name: PackageVersions
   type: string
   default: '.*'
@@ -65,7 +68,7 @@ parameters:
 
 jobs:
 - job: ${{ parameters.JobName }}
-  timeoutInMinutes: 360
+  timeoutInMinutes: ${{ parameters.TimeoutInMinutes }}
   strategy:
     matrix:
       ${{ if contains(parameters.OperatingSystems, 'Linux') }}:
@@ -109,7 +112,7 @@ jobs:
   - template: /eng/common/pipelines/templates/steps/verify-agent-os.yml
     parameters:
       AgentImage: $(OSVmImage)
-
+      
   - ${{ parameters.InstallLanguageSteps }}
 
   - template: /eng/common/TestResources/deploy-test-resources.yml
@@ -118,17 +121,12 @@ jobs:
       Location: westus
       ResourceType: perf
 
-  - pwsh: |
-      set-content -path config.yml -value "WorkingDirectories:"
-      add-content -path config.yml -value "  ${{ parameters.Language }}: $(Agent.BuildDirectory)/s"
-    workingDirectory: azure-sdk-tools/tools/perf-automation/Azure.Sdk.Tools.PerfAutomation
-    displayName: Create config.yml
-
   - script: >-
       dotnet run -- run
-      --no-sync
-      --languages ${{ parameters.Language }}
-      --services "${{ parameters.Services }}"
+      --language ${{ parameters.Language }}
+      --language-version ${{ parameters.LanguageVersion }}
+      --repo-root $(System.DefaultWorkingDirectory)
+      --tests-file $(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}/perf-tests.yml
       --package-versions "${{ parameters.PackageVersions }}"
       --tests "${{ parameters.Tests }}"
       --arguments "${{ parameters.Arguments }}"

@@ -22,7 +22,7 @@ stages:
           matrix:
             Windows:
               Pool: 'azsdk-pool-mms-win-2022-general'
-              Image: 'MMS2022'
+              Image: 'windows-2022'
             Linux:
               Pool: azsdk-pool-mms-ubuntu-2204-general
               Image: MMSUbuntu22.04

@@ -18,8 +18,8 @@ steps:
     - task: NodeTool@0
       condition: and(succeededOrFailed(), ne(variables['Skip.SpellCheck'],'true'))
       inputs:
-        versionSpec: 18.x
-      displayName: Use Node.js 18.x
+        versionSpec: 18.13.0
+      displayName: Use Node.js 18.13.0
 
     - task: PowerShell@2
       displayName: Check spelling (cspell)

@@ -4,7 +4,9 @@
 param (
     [Parameter(Position=0)]
     [ValidateNotNullOrEmpty()]
-    [string] $ProjectDirectory
+    [string] $ProjectDirectory,
+    [Parameter(Position=1)]
+    [string] $CadlAdditionalOptions ## addtional cadl emitter options, separated by semicolon if more than one, e.g. option1=value1;option2=value2
 )
 
 $ErrorActionPreference = "Stop"
@@ -78,6 +80,12 @@ try {
         }
     }
     $cadlCompileCommand = "npx cadl compile $mainCadlFile --emit $emitterName$emitterAdditionalOptions"
+    if ($CadlAdditionalOptions) {
+        $options = $CadlAdditionalOptions.Split(";");
+        foreach ($option in $options) {
+            $cadlCompileCommand += " --option $emitterName.$option"
+        }
+    }
     Write-Host($cadlCompileCommand)
     Invoke-Expression $cadlCompileCommand
 

@@ -44,10 +44,10 @@ function GetGitRemoteValue([string]$repo) {
         $gitRemotes = (git remote -v)
         foreach ($remote in $gitRemotes) {
             if ($remote.StartsWith("origin")) {
-                if ($remote -match 'https://github.com/\S+[\.git]') {
+                if ($remote -match 'https://github.com/\S+') {
                     $result = "https://github.com/$repo.git"
                     break
-                } elseif ($remote -match "[email protected]:\S+[\.git]"){
+                } elseif ($remote -match "[email protected]:\S+"){
                     $result = "[email protected]:$repo.git"
                     break
                 } else {

@@ -202,6 +202,7 @@ begin {
         "azure-genomics",
         "azure-hdinsight",
         "azure-hdinsight-rserver",
+        "azure-health-insights",
         "azure-hpc-cache",
         "azure-immersive-reader",
         "azure-information-protection",
@@ -321,6 +322,7 @@ begin {
         "azure-vpn-gateway",
         "azure-web-application-firewall",
         "azure-web-apps",
+        "azure-web-pubsub",
         "azure-webapp-containers",
         "blazor-server",
         "blazor-webassembly",

@@ -34,6 +34,9 @@ function CreateReleases($pkgList, $releaseApiUrl, $releaseSha) {
       body             = $releaseNotes
     }
 
+    Write-Host "Post Request Body:"
+    Write-Host $body
+
     $headers = @{
       "Content-Type"  = "application/json"
       "Authorization" = "token $($env:GH_TOKEN)"

@@ -1,5 +1,6 @@
 # Note, due to how `Expand-Archive` is leveraged in this script,
 # powershell core is a requirement for successful execution.
+[CmdletBinding()]
 param (
   $AzCopy,
   $DocLocation,
@@ -199,32 +200,32 @@ function Upload-Blobs
     LogDebug "Final Dest $($DocDest)/$($PkgName)/$($DocVersion)"
     LogDebug "Release Tag $($ReleaseTag)"
 
-    # Use the step to replace default branch link to release tag link 
+    # Use the step to replace default branch link to release tag link
     if ($ReleaseTag) {
-        foreach ($htmlFile in (Get-ChildItem $DocDir -include *.html -r)) 
+        foreach ($htmlFile in (Get-ChildItem $DocDir -include *.html -r))
         {
             $fileContent = Get-Content -Path $htmlFile -Raw
             $updatedFileContent = $fileContent -replace $RepoReplaceRegex, "`${1}$ReleaseTag"
             if ($updatedFileContent -ne $fileContent) {
                 Set-Content -Path $htmlFile -Value $updatedFileContent -NoNewLine
             }
         }
-    } 
+    }
     else {
         LogWarning "Not able to do the default branch link replacement, since no release tag found for the release. Please manually check."
-    } 
-   
+    }
+
     LogDebug "Uploading $($PkgName)/$($DocVersion) to $($DocDest)..."
     & $($AzCopy) cp "$($DocDir)/**" "$($DocDest)/$($PkgName)/$($DocVersion)$($SASKey)" --recursive=true --cache-control "max-age=300, must-revalidate"
-    
+
     LogDebug "Handling versioning files under $($DocDest)/$($PkgName)/versioning/"
     $versionsObj = (Update-Existing-Versions -PkgName $PkgName -PkgVersion $DocVersion -DocDest $DocDest)
-    $latestVersion = $versionsObj.LatestGAPackage 
+    $latestVersion = $versionsObj.LatestGAPackage
     if (!$latestVersion) {
-        $latestVersion = $versionsObj.LatestPreviewPackage 
+        $latestVersion = $versionsObj.LatestPreviewPackage
     }
     LogDebug "Fetching the latest version $latestVersion"
-    
+
     if ($UploadLatest -and ($latestVersion -eq $DocVersion))
     {
         LogDebug "Uploading $($PkgName) to latest folder in $($DocDest)..."
@@ -243,3 +244,9 @@ else
     See https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/common_engsys.md#code-structure"
 }
 
+# If we hit a failure then dump out the azcopy logs to help with debugging
+if ($LASTEXITCODE)
+{
+    Write-Host "Copying failed with error code [$LASTEXITCODE]. Dumping the logs to help diagnose."
+    Get-ChildItem $env:UserProfile\.azcopy -Filter *.log | ForEach-Object { "LOG: " + $_; Get-Content $_; }
+}