-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test recordings #19974
Closed
Closed
Move test recordings #19974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RickWinter
requested review from
chlowell,
jhendrixMSFT and
richardpark-msft
as code owners
February 8, 2023 01:35
…19975) Increment package version after release of containers/azcontainerregistry
…ype *string to []*AggregationType (Azure#19981)
Increment package version after release of monitor/azquery
* Add 1.20 to the matrix * Update uses of rand.Seed to rand.NewSource
* fix wrong order of require.Equal arguments * use require.True/False instead
* Remove language from profile zip * Revert "Remove language from profile zip" This reverts commit 2f670435b25f89955338170a7bdfbe4432cbe23f. * Remove Services parameter * Fix path to tests-file * Run both sync and async tests by default * Add LanguageVersion to common perf.yml --------- Co-authored-by: Mike Harder <[email protected]>
* Added a few service client tests and some changes to testcommon * Fixed type of arg * Addressed comments from PR * Modified some tests and uploaded some assets * make sas unrecorded * fix ineffassign * Removing deprecated import * Ignoring unused lint --------- Co-authored-by: siminsavani-msft <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
* Update `CODEOWNERS` paths: fix invalid paths As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534 * Update .github/CODEOWNERS Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: archerzz <[email protected]>
* fix changelog function filter * add test * fix * rename to BeginDelete * add test...
…nder) (Azure#19992) Fixing issues where we could over-request credit (Azure#19965) or allow for negative/zero credits (Azure#19743), both of which could cause issues with go-amqp.. Fixes Azure#19965 Fixes Azure#19743
Co-authored-by: Konrad Jamrozik <[email protected]>
We have better automation now, no longer need this.
* Generate Code for AzQueue (Azure#19729) * first generation * removed queuename from url param * fixed georep * removed pagination * move to internal * last generation * [Feature] Queue Service Client + Key Credential Authentication (Azure#19732) * first generation * removed queuename from url param * fixed georep * removed pagination * added basic methods * added basic models * regenrated and added pager * regenrated and added pager * autorest comment change * comments * comments * comments * version change * marker * rename to queue * further cleanup * rename service client * add license * Enable CI for azqueue (Azure#19835) * Update to latest code generator for azqueue (Azure#19837) * Update to latest code generator for azqueue Add build.go and format generated code. * add changelog * [Feature] SAS Support + Test Framework (Azure#19756) * first generation * removed queuename from url param * fixed georep * removed pagination * added basic methods * added basic models * regenrated and added pager * regenrated and added pager * autorest comment change * comments * comments * comments * added sas perms and basic tests * spell check * cleanup * version change * added sas method for service client * uncomment test * cleanup * cleanup * sas test * cleanup * new test framework * update internal module to support test assets * set code coverage floor * fixed linter Co-authored-by: Joel Hendrix <[email protected]> * Queue Client + More Tests (Azure#19852) * added basic queue client * added create and delete queue * added tests to service client for queues * added test to ensure pagination behaves correctly * updated tests * added TODOs * more tests * assets * lint * added more queue methods * more methods * added tests * export * export * export * added more tests * cleanup * address comments * removed message id from composite * removed account services and cleaned up * renamed cors * renamed cors * fixed cors test failure * lint * Queues Live Pipeline + APIViews Feedback (Azure#19955) * removed item suffix * test resources file * lint fix * renamed queues list * fix * More Service Client and Queue Client Tests (Azure#19958) * removed item suffix * test resources file * lint fix * added more service client tests * added more service client tests * fix tests * fix tests * added more message related tests * added peek message tests * cleaup * added tests for clear and delete * added update tests * more code coverage * cleanup * added stats test * added one more test * removed test * added client tests * more sas tests * more tests * AzQueue Public Preview APIVIew Feedback (Azure#20003) * Resolve APIView feedback for Public Preview * test * More api view comments * expose GRS * constants * tests * cleanup * Changelog Entry + doc.go File + Basic Samples (Azure#20004) * added basic doc * added a doc.go file * sample todos * added readme file * readme update * cleanup * cleanup * added samples * go update * go update * link fix --------- Co-authored-by: Joel Hendrix <[email protected]>
* autotrigger the tables CI when a testproxy file is changed
* [Release] sdk/resourcemanager/liftrqumulo/armqumulo/0.1.0 generation from spec commit: 9918780b4dc4bdc111cf3facc11561904d609ad7 * Update CHANGELOG.md
* Add parameter TimeoutInMinutes * Update pools and images to latest * Remove all usage of vmImage --------- Co-authored-by: Mike Harder <[email protected]>
* Nil partition key * Changelog * Update CHANGELOG.md * Tests for Null Partition Key * Unit Tests for Null Partition Key CRUD Operations on Emulator * NullPartitionKey variable instead of function * Typo Edit * Docstring
…ebus and eventhubs. (Azure#20335) Updating to use the latest nhooyr.io/websocket package in both servicebus and eventhubs. * Expanding the websockets descriptions and tests to go end-to-end. Prior tests weren't closing the connection and were hiding an error that was coming back from the underlying package. * The examples also document how to use an HTTP proxy with websockets, which is a common combination. * One of the tests also contains the necessary incantations to make it the entire websocket conversation wireshark-able. Partially fixes Azure#16924
Adding guidance on the proper usage of 3rd Party Libraries in our samples.
* add healthinsights to Test-SampleMetadata script * spacing * update productSlug to azure-health-insights --------- Co-authored-by: Asaf Levi <[email protected]>
* Adding tests for appendblob * Updating unrecorded tests and fixing tests * Adding deprecated message on unsupported apis * Update tests * update * Updating docs references on deprecated apis * Fix flaky test * Update sdk/storage/azblob/appendblob/client.go Co-authored-by: Sourav Gupta <[email protected]> * Update sdk/storage/azblob/appendblob/client.go Co-authored-by: Sourav Gupta <[email protected]> * Fixing flaky tests, again... --------- Co-authored-by: Sourav Gupta <[email protected]>
* Use underlying error when checking for context errors There is a race between error propagation and closing a context's deadline channel. The result is that while the API that takes a context returns the correct error, context.Err() might return nil. See golang/go#31863 for more info. * further refinements * revert ordering of error check * add changelog entry
* Update dependencies * Fix dependencies and update perf test * Fixup azkeys tests
RickWinter
requested review from
benbp,
weshaggard,
jsquire,
ronniegeraghty,
siminsavani-msft,
souravgupta-msft,
tasherif-msft,
gapra-msft,
vibhansa-msft,
ArcturusZhang,
lirenhe,
tadelesh,
gracewilcox,
ealsur,
kirankumarkolli and
antkmsft
as code owners
March 15, 2023 23:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assets.json for test recordings
Move test recordings out of the repository