Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append Blob Tests #20399

Merged
merged 11 commits into from
Mar 15, 2023
Merged

Append Blob Tests #20399

merged 11 commits into from
Mar 15, 2023

Conversation

siminsavani-msft
Copy link
Contributor

@siminsavani-msft siminsavani-msft commented Mar 13, 2023 •
edited
Loading

Adding missing tests for APIs in AppendBlob

Ignored/removed APIs:

  1. SetTier - deprecated from appendblob client, this not an api for appendblob
  2. CopyFromURL - deprecated from appendblob client, this not api for appendblob
  3. AbortCopyFromURL - existing blob base client tests
  4. DownloadFile - existing blob base client tests

Written tests for:

  1. SetMetadata
  2. SetHTTPHeaders
  3. SetTags
  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 13, 2023
@vibhansa-msft vibhansa-msft added this to the azblob v1.0.1 milestone Mar 14, 2023
@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft siminsavani-msft merged commit 0e71c85 into main Mar 15, 2023
@siminsavani-msft siminsavani-msft deleted the siminsavani/appendblob-tests branch March 15, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@vibhansa-msft vibhansa-msft vibhansa-msft approved these changes

@souravgupta-msft souravgupta-msft souravgupta-msft approved these changes

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

Assignees
No one assigned
Labels
AzBlob Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
azblob v1.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@siminsavani-msft @jhendrixMSFT @gapra-msft @vibhansa-msft @souravgupta-msft