Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append Blob Tests #20399

Merged
merged 11 commits into from
Mar 15, 2023
Merged

Append Blob Tests #20399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2d6120
Adding tests for appendblob
siminsavani-msft Mar 13, 2023
0501cd0
Updating unrecorded tests and fixing tests
siminsavani-msft Mar 14, 2023
ef9025a
Adding deprecated message on unsupported apis
siminsavani-msft Mar 14, 2023
bd7ee72
Update tests
siminsavani-msft Mar 14, 2023
cf91d28
update
siminsavani-msft Mar 14, 2023
cb3bd2a
Updating docs references on deprecated apis
siminsavani-msft Mar 14, 2023
01b6325
Fix flaky test
siminsavani-msft Mar 14, 2023
a3257a3
Update sdk/storage/azblob/appendblob/client.go
siminsavani-msft Mar 15, 2023
6d9792f
Update sdk/storage/azblob/appendblob/client.go
siminsavani-msft Mar 15, 2023
96c928e
Fixing flaky tests, again...
siminsavani-msft Mar 15, 2023
e68db3c
Merge branch 'siminsavani/appendblob-tests' of https://github.com/Azu…
siminsavani-msft Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions sdk/storage/azblob/appendblob/client.go
View file
Open in desktop
jhendrixMSFT marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ package appendblob

import (
"context"
"errors"
"io"
"os"
"time"
Expand Down Expand Up @@ -255,14 +256,10 @@ func (ab *Client) SetLegalHold(ctx context.Context, legalHold bool, options *blo
return ab.BlobClient().SetLegalHold(ctx, legalHold, options)
}

// SetTier operation sets the tier on a blob. The operation is allowed on a page
// blob in a premium storage account and on a block blob in a blob storage account (locally
// redundant storage only). A premium page blob's tier determines the allowed size, IOPS, and
// bandwidth of the blob. A block blob's tier determines Hot/Cool/Archive storage type. This operation
// does not update the blob's ETag.
// For detailed information about block blob level tiering see https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-storage-tiers.
// SetTier
// Deprecated: SetTier only works for page blob in premium storage account and block blob in blob storage account.
func (ab *Client) SetTier(ctx context.Context, tier blob.AccessTier, o *blob.SetTierOptions) (blob.SetTierResponse, error) {
siminsavani-msft marked this conversation as resolved.
Show resolved Hide resolved
return ab.BlobClient().SetTier(ctx, tier, o)
return blob.SetTierResponse{}, errors.New("Operation will not work on this blob type. SetTier only works for page blob in premium storage account and block blob in blob storage account.")
}

// SetExpiry operation sets an expiry time on an existing blob. This operation is only allowed on Hierarchical Namespace enabled accounts.
Expand Down Expand Up @@ -326,10 +323,10 @@ func (ab *Client) GetTags(ctx context.Context, o *blob.GetTagsOptions) (blob.Get
return ab.BlobClient().GetTags(ctx, o)
}

// CopyFromURL synchronously copies the data at the source URL to a block blob, with sizes up to 256 MB.
// For more information, see https://docs.microsoft.com/en-us/rest/api/storageservices/copy-blob-from-url.
// CopyFromURL
// Deprecated: CopyFromURL works only with block blob
siminsavani-msft marked this conversation as resolved.
Show resolved Hide resolved
func (ab *Client) CopyFromURL(ctx context.Context, copySource string, o *blob.CopyFromURLOptions) (blob.CopyFromURLResponse, error) {
siminsavani-msft marked this conversation as resolved.
Show resolved Hide resolved
return ab.BlobClient().CopyFromURL(ctx, copySource, o)
return blob.CopyFromURLResponse{}, errors.New("Operation will not work on this blob type. CopyFromURL works only with block blob.")
}

// Concurrent Download Functions -----------------------------------------------------------------------------------------
Expand Down
Loading