Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS paths: fix invalid paths and deprioritize /eng/ and Engineering System Team paths #33221

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Jan 31, 2023

As part of ongoing work of enabling wildcard support for CODEOWNERS:

and enabling stricter validation:

this PR:

As a consequence of this PR possibly the automatically assigned PR reviewers will change for some paths. The full list of of such changes can be determined by running relevant test provided by this PR:

You can also reach out to me to get that information.

Once this PR is merged, I will enable the new CODEOWNERS matcher, similar to how it was done for net repo by these two PRs:

Doing so will also change to whom build failure notification emails are sent.

Related PRs:

Build failure notification recipients changes

For a build definition whose source is PATH, now its build failure notification recipients will be RIGHT OWNERS, while previously they where LEFT OWNERS:

image

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jan 31, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jan 31, 2023
@konrad-jamrozik konrad-jamrozik requested a review from a team January 31, 2023 00:53
# Conflicts:
#	.github/CODEOWNERS
@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit f7349d6 into main Jan 31, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/co branch January 31, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants