Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency-Testing] Enable minmax testing on packages from NPM feed. #14950

Closed
armansabaa opened this issue Apr 20, 2021 · 0 comments · Fixed by #18796
Closed

[Dependency-Testing] Enable minmax testing on packages from NPM feed. #14950

armansabaa opened this issue Apr 20, 2021 · 0 comments · Fixed by #18796
Assignees
@KarishmaGhiya
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Milestone
[2022] January

Comments

@armansabaa
Copy link
Contributor

Describe the bug
Turning on minmax testing for @azure/communication-chat package, dependency test jobs fails to retrieve package
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=852608&view=logs&j=3a7b9694-9187-531d-f2c8-3fe11d27bb4e&t=1fe0d3bf-00b5-5da5-0c90-c5224a36b2a3
image

Try/catch and nullcheck can be added here or in packageUtils.getRushSpec as a fix.
image

Also probably want to change the step Convert tests to run against package references in the pipeline to actually fail if something goes wrong.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 20, 2021
@KarishmaGhiya KarishmaGhiya added the Central-EngSys This issue is owned by the Engineering System team. label Apr 20, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 20, 2021
@armansabaa armansabaa mentioned this issue Apr 20, 2021
Merged
@kurtzeborn kurtzeborn added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. and removed Central-EngSys This issue is owned by the Engineering System team. labels Apr 26, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] July milestone Jun 15, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jul 4, 2021
CodeGen from PR 14950 in Azure/azure-rest-api-specs
543a1a2 
New api version support to include disable local auth flag for event hub (Azure#14950)

* New api version support to include disable local auth flag for event hub

* Updated api-version in examples

* Added auth examples in NameSpaces

* Fixing LintDiff error

* Fixing LintDiff error contd

* Removed UserassignedIdentities as part of definition

* Changed to UserAssignedIdentity as a reference in userAssignedIdentities object

Co-authored-by: Sayan Ghosh <[email protected]>
@sadasant sadasant mentioned this issue Sep 23, 2021
Closed
@KarishmaGhiya KarishmaGhiya mentioned this issue Nov 23, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
[2022] January
Development

Successfully merging a pull request may close this issue.

Min max npm KarishmaGhiya/azure-sdk-for-js
4 participants
@armansabaa @KarishmaGhiya @ramya-rao-a @kurtzeborn