Min max npm #18796

KarishmaGhiya · 2021-11-23T09:04:31Z

Update logic to update azure package dependencies from outside the repo too
Update logic to run min-max testing on third party dependencies
Update integration-test - node script to take the timeout from the package's package.json - Fixes [min-max] - Respect the package's timeout when running integration test #16731
Verify logic working or not on identity and communication-chat package
Fixes [Dependency-Testing] Enable minmax testing on packages from NPM feed. #14950
Verification run - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1258044&view=results (If you see one failing test, it's because that one test is failing on ubuntu - unrelated to min-max)

eng/tools/dependency-testing/index.js

sadasant · 2021-12-21T11:52:43Z

eng/tools/dependency-testing/index.js

      }
    }
+    else if (versionType === "same") {
+      return packageJsonDepVersion;
+    }


Good improvements!

eng/tools/dependency-testing/index.js

eng/tools/dependency-testing/templates/tsconfig.json

sdk/identity/identity/tests.yml

witemple-msft · 2021-12-21T15:34:41Z

eng/tools/dependency-testing/index.js

  }
  testPackageJson.dependencies = depList;

  for (const package of Object.keys(packageJsonContents.devDependencies)) {
    testPackageJson.devDependencies[package] = packageJsonContents.devDependencies[package];
-    if (package.startsWith("@azure/")) {
+    if (package.startsWith("@azure/") || package.startsWith("@azure-rest/")) {


Could we test the package sdk-type field instead of looking at the namespace prefix?

dev-tool uses an @azure/ namespace, but it isn't a client SDK.

For that I will have to read the package.json contents of the package - might increase the parsing time. I think it should be ok. Since I am anyways filtering out the utility packages - so not running min-max on the dev-tool and other utility packages.

Alright, as long as we've got a list then it doesn't matter very much.

eng/tools/dependency-testing/index.js

witemple-msft · 2021-12-21T15:37:18Z

eng/tools/dependency-testing/templates/package.json

@@ -9,7 +9,7 @@
  "scripts": {
    "build": "tsc -p .",
    "integration-test:browser": "karma start --single-run",
-    "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter mocha-multi-reporter.js --timeout 350000 --full-trace 'dist/**/*.js' --exit",
+    "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter mocha-multi-reporter.js --timeout 350000 --full-trace \"dist-esm/**/*.spec.js\" --exit",


Wouldn't this also run browser tests?

dist-esm/**/{,!(browser)/**/}*.spec.js - How about this?

eng/tools/dependency-testing/index.js

witemple-msft

Thanks for addressing my comments.

sadasant

Looks good! I love the comments ❤️ Thank you!

maorleger

🚀

dev-Sentinel-2022-05-01-preview (Azure#18796) * Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * Added fileImports.json (Azure#18540) * Added fileImports.json * add example files * move example files * delete old example files * fix get file import by id example * fix delete file import example * fix typos * resolve issues * fix date * more issue resolving * . * . * add location to delete example * support 200 * resolve comments * update example * remove whitespace * readonly * operationId * revert file imports (Azure#18663) * add securityMLAnalyticsSettings to securityInsights (Azure#18679) * add securityMLAnalyticsSettings to securityInsights * update for operationIdNounConflictingModelNames * update plurality * update * add settingsdefinintionid field for anomalySettings * Add Anomaly to timeline items (Azure#18675) * Add Anomaly to timeline items * Add exmaple of anomaly * Add x-ms-identifiers * fix issue fix x-m-id issue. fix lint * Change enum name * REmove timeline from inceidents * swap enum definistion and name * Align SKU descriptions (Azure#18874) * Align SKU descriptions * Remove Sku model from Settings as it's not in use and has conflict with another trype. * Update AutomationRules.json (Azure#18630) * Update automation rules swagger * Update examples * fix examples * fix naming typo * run prettier * run prettier on missing file * remove logic app arm id from required * remove a tag with errors (Azure#18916) Co-authored-by: moranraz <[email protected]> Co-authored-by: jungph808 <[email protected]> Co-authored-by: rpressburger <[email protected]> Co-authored-by: ityankel <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]>

KarishmaGhiya added 2 commits November 23, 2021 01:01

update the logic for min-max testing

219722b

test on identity

d050315

ghost added the Azure.Identity label Nov 23, 2021

KarishmaGhiya requested a review from sadasant November 23, 2021 09:08

KarishmaGhiya added 5 commits November 23, 2021 01:30

update scripts

91a7cff

update scripts

2e2364d

update the logic to dep-testing for azure packages on npm

adf8e0f

update the timeout logic

b21a3eb

enable min-max testing on third-party dependencies

5cdc8b1

KarishmaGhiya requested review from maorleger, ramya-rao-a and jeremymeng December 21, 2021 02:02

KarishmaGhiya marked this pull request as ready for review December 21, 2021 02:02

KarishmaGhiya requested review from benbp, deyaaeldeen, mikeharder, praveenkuttappan, weshaggard and witemple-msft as code owners December 21, 2021 02:02

KarishmaGhiya added 2 commits December 20, 2021 18:21

test communication-chat-test

d0b4eb5

test communication-chat build:test failing

0cb1810

KarishmaGhiya mentioned this pull request Dec 21, 2021

Wrapping up min-max testing #9442

Closed

sadasant reviewed Dec 21, 2021

View reviewed changes

eng/tools/dependency-testing/index.js Outdated Show resolved Hide resolved

sadasant reviewed Dec 21, 2021

View reviewed changes

eng/tools/dependency-testing/index.js Outdated Show resolved Hide resolved

sadasant reviewed Dec 21, 2021

View reviewed changes

eng/tools/dependency-testing/index.js Show resolved Hide resolved

sadasant reviewed Dec 21, 2021

View reviewed changes

eng/tools/dependency-testing/templates/tsconfig.json Show resolved Hide resolved

sadasant reviewed Dec 21, 2021

View reviewed changes

sdk/identity/identity/tests.yml Show resolved Hide resolved

witemple-msft reviewed Dec 21, 2021

View reviewed changes

maorleger reviewed Dec 21, 2021

View reviewed changes

eng/tools/dependency-testing/index.js Outdated Show resolved Hide resolved

eng/tools/dependency-testing/index.js Outdated Show resolved Hide resolved

KarishmaGhiya added 4 commits December 21, 2021 13:04

added some comments

073de14

update the test command to skip browser tests just in case

6424b72

ran prettier

363f107

flatten logic

0e69d34

witemple-msft approved these changes Dec 21, 2021

View reviewed changes

sadasant approved these changes Dec 21, 2021

View reviewed changes

maorleger approved these changes Dec 21, 2021

View reviewed changes

KarishmaGhiya enabled auto-merge (squash) December 21, 2021 21:54

KarishmaGhiya merged commit f3b630d into Azure:main Dec 21, 2021

KarishmaGhiya mentioned this pull request Jan 7, 2022

Communication Chat - enable min-max testing #17880

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Min max npm #18796

Min max npm #18796

KarishmaGhiya commented Nov 23, 2021 •

edited

Loading

sadasant Dec 21, 2021

witemple-msft Dec 21, 2021

KarishmaGhiya Dec 21, 2021

witemple-msft Dec 21, 2021

witemple-msft Dec 21, 2021

KarishmaGhiya Dec 21, 2021

witemple-msft left a comment

sadasant left a comment

maorleger left a comment

Min max npm #18796

Min max npm #18796

Conversation

KarishmaGhiya commented Nov 23, 2021 • edited Loading

sadasant Dec 21, 2021

Choose a reason for hiding this comment

witemple-msft Dec 21, 2021

Choose a reason for hiding this comment

KarishmaGhiya Dec 21, 2021

Choose a reason for hiding this comment

witemple-msft Dec 21, 2021

Choose a reason for hiding this comment

witemple-msft Dec 21, 2021

Choose a reason for hiding this comment

KarishmaGhiya Dec 21, 2021

Choose a reason for hiding this comment

witemple-msft left a comment

Choose a reason for hiding this comment

sadasant left a comment

Choose a reason for hiding this comment

maorleger left a comment

Choose a reason for hiding this comment

KarishmaGhiya commented Nov 23, 2021 •

edited

Loading