Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iotspaces - cspell found spelling errors #17204

Closed
danieljurek opened this issue Aug 26, 2021 · 1 comment
Closed

iotspaces - cspell found spelling errors #17204

danieljurek opened this issue Aug 26, 2021 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@danieljurek
Copy link
Member

danieljurek commented Aug 26, 2021 •
edited
Loading

Spell check scanning of iotspaces detected spelling errors. This service directory is opted out of PR spell checking in PR #17142 to keep merges unblocked.

What to do

  1. Ensure Node.js is installed (https://nodejs.org/en/download/). This will include npx
  2. Delete the service's entry in .vscode/cspell.json's ignorePaths field. It will look like: sdk/iotspaces/**/*. You need to do this to enable checking the files.
  3. From the root of the repo run spell check using npx cspell lint --config '.vscode/cspell.json' --no-must-find-files "sdk/iotspaces/**"
  4. Fix detections according to http://aka.ms/azsdk/engsys/spellcheck use the "False positives" section to fix false positives
  5. Check in changes (including the change to .vscode/cspell.json where the ignorePaths is updated to remove the entry for this service.). You may need to run git add -f .vscode/cspell.json to force adding the changes to the file in git.

Spell checking output

/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/package.json:2:23 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/package.json:19:23 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/package.json:51:77 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/package.json:51:111 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/README.md:13:24 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/README.md:32:80 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/README.md:65:23 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/README.md:69:42 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/README.md:81:37 - Unknown word (Iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/rollup.config.js:9:23 - Unknown word (iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/rollup.config.js:11:21 - Unknown word (Iotspaces)
/home/djurek/azure-sdk-for-js/sdk/iotspaces/arm-iotspaces/src/ioTSpacesClientContext.ts:15:33 - Unknown word (iotspaces)
@danieljurek danieljurek added the Client This issue points to a problem in the data-plane of the library. label Aug 26, 2021
@ramya-rao-a ramya-rao-a added the EngSys This issue is impacting the engineering system. label Aug 26, 2021
@ramya-rao-a
Copy link
Contributor

All spell check errors are for an auto generated package and we don't intend to make any fixes for such packages

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jan 6, 2022
@mkarmark @SatishRanjan
@calvinsID @JennyLawrance @sanchitmehta
CodeGen from PR 16506 in Azure/azure-rest-api-specs
000209e 
Web ant95 2021 03 01 (Azure#16506)

* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080)

* Update StaticSites.json

* Update StaticSites.json

* Onedeploy API swapper spec (Azure#15985)

* Onedeploy API swapper spec

* Adding onedeploy custom keyword

* Formatting onedeploy api indentation

Formatting onedeploy api indentation

* prettifier

Co-authored-by: Calvin Chan <[email protected]>

* Fix status codes for syncfunctiontriggers (Azure#16413)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427)

* Add GET endpoint at /config/authsettingsv2 for Microsoft.Web

* Fix duplicate operation ids

* Swagger for ASD Transfer out (Azure#16000)

* Add domain transfer out to swagger

* Prettifier

* Add 202 response for webapp restart

* Add certificate listHostnameBindingsOfCertificate

* Formatting

* Swagger for listHostnameBindings endpoint (Azure#16516)

* Swagger for listHostnameBindings endpoint

* Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917)

* ops

Co-authored-by: Naveed Aziz <[email protected]>

* User/jennylaw/containerapp (Azure#16657)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Add custom hostname sites endpoint (Azure#16745)

* Add custom hostname sites endpoint

* Fix models

* Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793)

* Pre-Prettier-commit

* Adding missing file

* Prettier fixes

* Add missing definitions

* Fix intendation in readme.md

* add suppressions

* Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger

* Fix sercret read property

* Prettier fix

* Model fix

* Prettier Fix #2

Co-authored-by: Jenny Lawrance <[email protected]>

* Add long running extension for restart (Azure#16791)

* Remove unused API from ANT95 swagger (Azure#16901)

* Address PR comments (Azure#17019)

* Fixing PR comments (Azure#17127)

* Remove Certificate Hostname bindings API (Azure#17204)

* Remove Certificate Hostname bindings API

* Remove examples file as well

Co-authored-by: mkarmark <[email protected]>
Co-authored-by: SatishRanjan <[email protected]>
Co-authored-by: Calvin Chan <[email protected]>
Co-authored-by: Connor McMahon <[email protected]>
Co-authored-by: JennyLawrance <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieljurek @ramya-rao-a