[Recorder] Adding a note in the readme to release publicly and rename the package(everywhere) #17127
Conversation
HarshaNalluru
requested review from
ramya-rao-a,
sarangan12,
jeremymeng,
bterlson,
xirzec and
qiaozha
sdk/test-utils/recorder/README.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| ## Azure test-utils-recorder SDK client library for JavaScript | |||
There was a problem hiding this comment.
@bterlson suggests releasing under @azure-tools scope.
There was a problem hiding this comment.
azure-tools or azure-sdk-tools?
There was a problem hiding this comment.
Sounds good as well, azure-sdk-tools seems more relevant to us. :)
@azure/test-utils-recorder changes to one of the following
@azure-tools/test-utils-recorder@azure-sdk-tools/test-utils-recorder(too long)@azure-tools/recorder@azure-sdk-tools/recorder(this?)
Picking @azure-sdk-tools/test-recorder as @ramya-rao-a suggesed, any objections or any other suggestions?
There was a problem hiding this comment.
I wonder if LLC package can also make use of this test recorder libraries ?
There was a problem hiding this comment.
If yes, would it be more appropriate to use @azure-tools scope ?
There was a problem hiding this comment.
Now, I'm inclined to @azure-tools/test-recorder
There was a problem hiding this comment.
I wonder if LLC package can also make use of this test recorder libraries ?
Currently, it supports only the SDKs in this repository because we rely on the file structure of this repo to be able to generate and pick up the recordings. We can support external packages but would need extra work to allow passing file paths as such at the very least. Any example you have in mind, @qiaozha?
I just realized.. is LLC the low level client? If they follow the same structure as other packages in this repo, we can use it. 😁
|
Just waiting for a couple hundred checks in the CI. :) |
HarshaNalluru
requested review from
0rland0Wats0n,
ankitarorabit,
chradek,
deyaaeldeen,
DominikMe,
dpwatrous,
ellismg,
EmmaZhu,
jiacfan,
joheredi,
KarishmaGhiya and
LarryOsterman
as code owners
HarshaNalluru
requested review from
martinbarnas-ms,
mikeharder,
nguerrera,
paterasMSFT,
petrsvihlik,
richardpark-msft,
schaabs,
vicancy,
vinjiang,
vishnureddy17,
witemple-msft,
XiaoningLiu,
YoDaMa,
zfengms and
a team
as code owners
HarshaNalluru
changed the title
|
/check-enforcer override |
|
Talked to @praveenkuttappan about releasing the package. |
Web ant95 2021 03 01 (Azure#16506) * Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (Azure#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <[email protected]> * Fix status codes for syncfunctiontriggers (Azure#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (Azure#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (Azure#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * ops Co-authored-by: Naveed Aziz <[email protected]> * User/jennylaw/containerapp (Azure#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (Azure#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix #2 Co-authored-by: Jenny Lawrance <[email protected]> * Add long running extension for restart (Azure#16791) * Remove unused API from ANT95 swagger (Azure#16901) * Address PR comments (Azure#17019) * Fixing PR comments (Azure#17127) * Remove Certificate Hostname bindings API (Azure#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <[email protected]> Co-authored-by: SatishRanjan <[email protected]> Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Connor McMahon <[email protected]> Co-authored-by: JennyLawrance <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]>
Background
test-utils-recorderpackage is a devDependency of our packages and is maintained by the rush infra, is not published to the npm.Problem
@qiaozha has been working on getting the test framework set up for the generated SDKs in the generator repo, PR at Azure/autorest.typescript#1162.
This depends on the test-utils-recorder project. The CI fails because the test-utils-recorder library is not published to npm.
As there didn't seem to be any simpler solutions to address the problem, we are considering publishing the
@azure/test-utils-recorderpackage to npm as suggested by @sarangan12.This is the PR that adds a note in the readme stating it is not meant for public utilization.
(We may have to do the same for other utility packages if they need to be published in the future for the same reason.)
As part of publishing, we are renaming this to
@azure-tools/test-recorder.