-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] ATOM API: Allow configuring the rule with createSubscription #12495
Conversation
…to CraeteRuleOptions
// @public | ||
export interface CreateSubscriptionOptions extends OperationOptions { | ||
autoDeleteOnIdle?: string; | ||
availabilityStatus?: EntityAvailabilityStatus; | ||
deadLetteringOnFilterEvaluationExceptions?: boolean; | ||
deadLetteringOnMessageExpiration?: boolean; | ||
defaultMessageTimeToLive?: string; | ||
defaultRuleOptions?: CreateRuleOptions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could have gone with an overload instead. But the new overload looked messy with three different kinds of option bags.
// Existing
createSubscription(
topicName: string,
subscriptionName: string,
options?: CreateSubscriptionOptions // Includes OperationOptions
): Promise<WithResponse<SubscriptionProperties>>;
// New Overload to allow configuring the rule
createSubscription(
topicName: string,
subscriptionName: string,
subscriptionOptions?: CreateSubscriptionOptions,
ruleOptions?: CreateRuleOptions,
operationOptions?: OperationOptions
): Promise<WithResponse<SubscriptionProperties>>
Hence making defaultRuleOptions?: CreateRuleOptions
an option inside the existing CreateSubscriptionOptions
instead of adding a new overload.
@@ -515,7 +523,7 @@ export interface SubscriptionProperties { | |||
status: EntityStatus; | |||
readonly subscriptionName: string; | |||
readonly topicName: string; | |||
userMetadata: string; | |||
userMetadata?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From testing, observed that this is possible to be undefined.
/azp run js - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/servicebus/service-bus/src/serializers/subscriptionResourceSerializer.ts
Outdated
Show resolved
Hide resolved
…eSerializer.ts Co-authored-by: Ramya Rao <[email protected]>
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
…to harshan/sb/issue/12345
…luru/azure-sdk-for-js into harshan/sb/issue/12345
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Issue #12345
Adding support to allow configuring the rule with createSubscription by taking the XML request from .NET SDK as reference.
(Thanks @JoshLove-msft)