[Service Bus] ATOM API: Allow configuring the rule with createSubscription

[HarshaNalluru]

Issue #12345

Adding support to allow configuring the rule with createSubscription by taking the XML request from .NET SDK as reference.
(Thanks @JoshLove-msft)

[HarshaNalluru]

I could have gone with an overload instead. But the new overload looked messy with three different kinds of option bags.

// Existing
createSubscription(
    topicName: string,
    subscriptionName: string,
    options?: CreateSubscriptionOptions // Includes OperationOptions
  ): Promise<WithResponse<SubscriptionProperties>>;
// New Overload to allow configuring the rule
createSubscription(
    topicName: string,
    subscriptionName: string,
    subscriptionOptions?: CreateSubscriptionOptions,
    ruleOptions?: CreateRuleOptions,
    operationOptions?: OperationOptions
  ): Promise<WithResponse<SubscriptionProperties>>

Hence making defaultRuleOptions?: CreateRuleOptions an option inside the existing CreateSubscriptionOptions instead of adding a new overload.

[HarshaNalluru]

From testing, observed that this is possible to be undefined.

[HarshaNalluru]

/azp run js - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

[ghost]

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.