-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] ATOM API: Allow configuring the rule with createSubscription #12495
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b5c097f
Split buildInternalRuleResource from rule serializer
HarshaNalluru fe2044a
reuse buildInternalRuleResource and add defaultRuleOptions attribute …
HarshaNalluru ea9ad74
Export CreateRuleOptions and organize exports
HarshaNalluru ef4383d
remove unneeded constant
HarshaNalluru dd16507
API Report
HarshaNalluru 4a9ea7a
Add a new test and verify the newly set rule
HarshaNalluru ad43397
Update sdk/servicebus/service-bus/src/serializers/subscriptionResourc…
HarshaNalluru 95425cb
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru 4e304ba
Inlining defaultRuleOptions
HarshaNalluru 2e7bfd9
Merge branch 'harshan/sb/issue/12345' of https://github.com/HarshaNal…
HarshaNalluru 4922ab6
fixing imports in tests
HarshaNalluru d2aa8c0
Fix imports and API report
HarshaNalluru 3005cbb
organize imports
HarshaNalluru fc9e383
remove CreateRuleOptions from the exports
HarshaNalluru 04cd48a
changelog
HarshaNalluru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From testing, observed that this is possible to be undefined.