Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ai-metrics-advisor] Segregate test folders into public and internal to enable min-max tests #12773

Merged
merged 3 commits into from
Dec 4, 2020
Merged

[ai-metrics-advisor] Segregate test folders into public and internal to enable min-max tests #12773

merged 3 commits into from
Dec 4, 2020

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Dec 3, 2020 •
edited by vishnureddy17
Loading

For detailed information on what we are doing in mim-max testing read this blog - https://devblogs.microsoft.com/azure-sdk/testing-semver-dependency-ranges/

Example of a PR for min-max tests enabling - #12694

  • Segregate the test files into internal and public folders
  • Enable min-max tests
  • Ensure the number of tests run in min-max = no of tests in the public folder

@KarishmaGhiya KarishmaGhiya self-assigned this Dec 3, 2020
@KarishmaGhiya KarishmaGhiya linked an issue Dec 3, 2020 that may be closed by this pull request
[metrics advisor] Separate metrics advisor tests into public and internal to enable min-max tests #12776
Closed
jeremymeng
jeremymeng approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the work!

@KarishmaGhiya KarishmaGhiya merged commit 80bf57d into Azure:master Dec 4, 2020
@KarishmaGhiya KarishmaGhiya deleted the separate-metrics-advisor branch December 4, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metrics advisor] Separate metrics advisor tests into public and internal to enable min-max tests
2 participants
@KarishmaGhiya @jeremymeng